Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): rebase 1.2.x plugins to their latest patch versions #2328

Merged
merged 24 commits into from
Oct 9, 2024

Conversation

kim-tsao
Copy link
Member

@kim-tsao kim-tsao commented Oct 8, 2024

Many plugins in the 1.2.x branch do not have room to bump the patch version for an upcoming CVE fix. This PR rebases the affected plugins to their latest patch versions (just before the Backstage 1.27 update).

The following backports should not regress the 1.2.x functionality as discussed with @schultzp2020 :

Fixes: https://issues.redhat.com/browse/RHIDP-4393

04kash and others added 22 commits October 8, 2024 15:35
…anus-idp#1756)

* chore: replaced Logger with backstage implementation LoggerService

Signed-off-by: Kashish Mittal <[email protected]>

* Update plugins/kiali-backend/src/plugin.ts

Co-authored-by: Paul Schultz <[email protected]>

* removed winstonLogger

Signed-off-by: Kashish Mittal <[email protected]>

* Update plugins/kiali-backend/src/clients/fetch.ts

Co-authored-by: Paul Schultz <[email protected]>

* changed log to logger

Signed-off-by: Kashish Mittal <[email protected]>

* changed longhand instances to shorthand

Signed-off-by: Kashish Mittal <[email protected]>

* fixed plugins/scaffolder-annotator-action/src/actions/annotator/mocks/catalog-info.yaml

Signed-off-by: Kashish Mittal <[email protected]>

* ran yarn install

Signed-off-by: Kashish Mittal <[email protected]>

* fixed type errors

Signed-off-by: Kashish Mittal <[email protected]>

* Update plugins/3scale-backend/src/providers/ThreeScaleApiEntityProvider.ts

Co-authored-by: Paul Schultz <[email protected]>

* Update plugins/orchestrator-backend/src/service/ScaffolderService.ts

Co-authored-by: Paul Schultz <[email protected]>

* Update plugins/orchestrator-backend/src/service/ScaffolderService.ts

Co-authored-by: Frank Kong <[email protected]>

---------

Signed-off-by: Kashish Mittal <[email protected]>
Co-authored-by: Paul Schultz <[email protected]>
Co-authored-by: Frank Kong <[email protected]>
…dependency (janus-idp#1811)

* chore: add the `postversion` script where it was missing.

Signed-off-by: David Festal <[email protected]>

* fix: `export-dynamic` should depend on `tsc` in turbo

Signed-off-by: David Festal <[email protected]>

---------

Signed-off-by: David Festal <[email protected]>
* **rbac:** add type checks with generics for audit log ([janus-idp#1789](janus-idp#1789)) ([ac69838](janus-idp@ac69838))

* **cli:** fix the removal of type definitions by `export-dynamic`. ([janus-idp#1810](janus-idp#1810)) ([8472d91](janus-idp@8472d91))
* **feedback:** fixed feedback backend plugin crashing ([janus-idp#1809](janus-idp#1809)) ([e4a571e](janus-idp@e4a571e))
* **feedback:** update EntityPage component ([janus-idp#1798](janus-idp#1798)) ([f5b04b5](janus-idp@f5b04b5))
* **kiali:** fix dev links ([janus-idp#1801](janus-idp#1801)) ([2a86a5e](janus-idp@2a86a5e))
* **kiali:** remove debug window ([janus-idp#1793](janus-idp#1793)) ([b5b5376](janus-idp@b5b5376))
* **kiali:** sanitize input for CWE-79 ([janus-idp#1786](janus-idp#1786)) ([9ba95bb](janus-idp@9ba95bb))
* missing postversion script is several plugins and missing turbo dependency ([janus-idp#1811](janus-idp#1811)) ([4dfe4f5](janus-idp@4dfe4f5))
* **orchestrator:** fix error handling in case data index failed to start ([janus-idp#1804](janus-idp#1804)) ([27affb7](janus-idp@27affb7))
* **topology:** remove check for catalog entity permission ([janus-idp#1800](janus-idp#1800)) ([fd6ae41](janus-idp@fd6ae41))

* **kiali:** update development doc for alpha backend([janus-idp#1720](janus-idp#1720)) ([e06e9be](janus-idp@e06e9be))
* **rbac:** add type checks with generics for audit log ([janus-idp#1789](janus-idp#1789)) ([ac69838](janus-idp@ac69838))

* **cli:** fix the removal of type definitions by `export-dynamic`. ([janus-idp#1810](janus-idp#1810)) ([8472d91](janus-idp@8472d91))
* **feedback:** fixed feedback backend plugin crashing ([janus-idp#1809](janus-idp#1809)) ([e4a571e](janus-idp@e4a571e))
* **feedback:** update EntityPage component ([janus-idp#1798](janus-idp#1798)) ([f5b04b5](janus-idp@f5b04b5))
* **kiali:** fix dev links ([janus-idp#1801](janus-idp#1801)) ([2a86a5e](janus-idp@2a86a5e))
* **kiali:** remove debug window ([janus-idp#1793](janus-idp#1793)) ([b5b5376](janus-idp@b5b5376))
* **kiali:** sanitize input for CWE-79 ([janus-idp#1786](janus-idp#1786)) ([9ba95bb](janus-idp@9ba95bb))
* missing postversion script is several plugins and missing turbo dependency ([janus-idp#1811](janus-idp#1811)) ([4dfe4f5](janus-idp@4dfe4f5))
* **orchestrator:** fix error handling in case data index failed to start ([janus-idp#1804](janus-idp#1804)) ([27affb7](janus-idp@27affb7))
* **topology:** remove check for catalog entity permission ([janus-idp#1800](janus-idp#1800)) ([fd6ae41](janus-idp@fd6ae41))

* **kiali:** update development doc for alpha backend([janus-idp#1720](janus-idp#1720)) ([e06e9be](janus-idp@e06e9be))
fix(feedback): Fixed feedback plugin crashing when integrations are not found

Signed-off-by: YashOswalYO <[email protected]>
* **cli:** fix the removal of type definitions by `export-dynamic`. ([janus-idp#1810](janus-idp#1810)) ([8472d91](janus-idp@8472d91))
* missing postversion script is several plugins and missing turbo dependency ([janus-idp#1811](janus-idp#1811)) ([4dfe4f5](janus-idp@4dfe4f5))
* **rbac:** add type checks with generics for audit log ([janus-idp#1789](janus-idp#1789)) ([ac69838](janus-idp@ac69838))

* **cli:** fix the removal of type definitions by `export-dynamic`. ([janus-idp#1810](janus-idp#1810)) ([8472d91](janus-idp@8472d91))
* **feedback:** fixed feedback backend plugin crashing ([janus-idp#1809](janus-idp#1809)) ([e4a571e](janus-idp@e4a571e))
* **feedback:** update EntityPage component ([janus-idp#1798](janus-idp#1798)) ([f5b04b5](janus-idp@f5b04b5))
* **kiali:** fix dev links ([janus-idp#1801](janus-idp#1801)) ([2a86a5e](janus-idp@2a86a5e))
* **kiali:** remove debug window ([janus-idp#1793](janus-idp#1793)) ([b5b5376](janus-idp@b5b5376))
* **kiali:** sanitize input for CWE-79 ([janus-idp#1786](janus-idp#1786)) ([9ba95bb](janus-idp@9ba95bb))
* missing postversion script is several plugins and missing turbo dependency ([janus-idp#1811](janus-idp#1811)) ([4dfe4f5](janus-idp@4dfe4f5))
* **orchestrator:** fix error handling in case data index failed to start ([janus-idp#1804](janus-idp#1804)) ([27affb7](janus-idp@27affb7))
* **topology:** remove check for catalog entity permission ([janus-idp#1800](janus-idp#1800)) ([fd6ae41](janus-idp@fd6ae41))

* **kiali:** update development doc for alpha backend([janus-idp#1720](janus-idp#1720)) ([e06e9be](janus-idp@e06e9be))
* **cli:** fix the removal of type definitions by `export-dynamic`. ([janus-idp#1810](janus-idp#1810)) ([8472d91](janus-idp@8472d91))
* **feedback:** fixed feedback backend plugin crashing ([janus-idp#1809](janus-idp#1809)) ([e4a571e](janus-idp@e4a571e))
* **feedback:** update EntityPage component ([janus-idp#1798](janus-idp#1798)) ([f5b04b5](janus-idp@f5b04b5))
* **kiali:** fix dev links ([janus-idp#1801](janus-idp#1801)) ([2a86a5e](janus-idp@2a86a5e))
* **kiali:** remove debug window ([janus-idp#1793](janus-idp#1793)) ([b5b5376](janus-idp@b5b5376))
* missing postversion script is several plugins and missing turbo dependency ([janus-idp#1811](janus-idp#1811)) ([4dfe4f5](janus-idp@4dfe4f5))
* **orchestrator:** fix error handling in case data index failed to start ([janus-idp#1804](janus-idp#1804)) ([27affb7](janus-idp@27affb7))
* **topology:** remove check for catalog entity permission ([janus-idp#1800](janus-idp#1800)) ([fd6ae41](janus-idp@fd6ae41))

* **kiali:** update development doc for alpha backend([janus-idp#1720](janus-idp#1720)) ([e06e9be](janus-idp@e06e9be))
* **rbac:** add type checks with generics for audit log ([janus-idp#1789](janus-idp#1789)) ([ac69838](janus-idp@ac69838))

* **cli:** fix the removal of type definitions by `export-dynamic`. ([janus-idp#1810](janus-idp#1810)) ([8472d91](janus-idp@8472d91))
* **feedback:** fixed feedback backend plugin crashing ([janus-idp#1809](janus-idp#1809)) ([e4a571e](janus-idp@e4a571e))
* **feedback:** update EntityPage component ([janus-idp#1798](janus-idp#1798)) ([f5b04b5](janus-idp@f5b04b5))
* **kiali:** fix dev links ([janus-idp#1801](janus-idp#1801)) ([2a86a5e](janus-idp@2a86a5e))
* **kiali:** remove debug window ([janus-idp#1793](janus-idp#1793)) ([b5b5376](janus-idp@b5b5376))
* **kiali:** sanitize input for CWE-79 ([janus-idp#1786](janus-idp#1786)) ([9ba95bb](janus-idp@9ba95bb))
* missing postversion script is several plugins and missing turbo dependency ([janus-idp#1811](janus-idp#1811)) ([4dfe4f5](janus-idp@4dfe4f5))
* **orchestrator:** fix error handling in case data index failed to start ([janus-idp#1804](janus-idp#1804)) ([27affb7](janus-idp@27affb7))
* **topology:** remove check for catalog entity permission ([janus-idp#1800](janus-idp#1800)) ([fd6ae41](janus-idp@fd6ae41))

* **kiali:** update development doc for alpha backend([janus-idp#1720](janus-idp#1720)) ([e06e9be](janus-idp@e06e9be))
* **cli:** fix the removal of type definitions by `export-dynamic`. ([janus-idp#1810](janus-idp#1810)) ([8472d91](janus-idp@8472d91))
* **feedback:** fixed feedback backend plugin crashing ([janus-idp#1809](janus-idp#1809)) ([e4a571e](janus-idp@e4a571e))
* missing postversion script is several plugins and missing turbo dependency ([janus-idp#1811](janus-idp#1811)) ([4dfe4f5](janus-idp@4dfe4f5))
* **rbac:** add type checks with generics for audit log ([janus-idp#1789](janus-idp#1789)) ([ac69838](janus-idp@ac69838))
* switch defaults of the `--embed-as-dependencies` and `in-place` options. ([janus-idp#1787](janus-idp#1787)) ([049e675](janus-idp@049e675))
## [1.4.14](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-06-13)

### Features

* **rbac:** add type checks with generics for audit log ([janus-idp#1789](janus-idp#1789)) ([ac69838](janus-idp@ac69838))

### Bug Fixes

* **cli:** fix the removal of type definitions by `export-dynamic`. ([janus-idp#1810](janus-idp#1810)) ([8472d91](janus-idp@8472d91))
* **feedback:** fixed feedback backend plugin crashing ([janus-idp#1809](janus-idp#1809)) ([e4a571e](janus-idp@e4a571e))
* **feedback:** update EntityPage component ([janus-idp#1798](janus-idp#1798)) ([f5b04b5](janus-idp@f5b04b5))
* **kiali:** fix dev links ([janus-idp#1801](janus-idp#1801)) ([2a86a5e](janus-idp@2a86a5e))
* **kiali:** remove debug window ([janus-idp#1793](janus-idp#1793)) ([b5b5376](janus-idp@b5b5376))
* **kiali:** sanitize input for CWE-79 ([janus-idp#1786](janus-idp#1786)) ([9ba95bb](janus-idp@9ba95bb))
* missing postversion script is several plugins and missing turbo dependency ([janus-idp#1811](janus-idp#1811)) ([4dfe4f5](janus-idp@4dfe4f5))
* **orchestrator:** fix error handling in case data index failed to start ([janus-idp#1804](janus-idp#1804)) ([27affb7](janus-idp@27affb7))
* **topology:** remove check for catalog entity permission ([janus-idp#1800](janus-idp#1800)) ([fd6ae41](janus-idp@fd6ae41))

### Documentation

* **kiali:** update development doc for alpha backend([janus-idp#1720](janus-idp#1720)) ([e06e9be](janus-idp@e06e9be))
* **rbac:** add type checks with generics for audit log ([janus-idp#1789](janus-idp#1789)) ([ac69838](janus-idp@ac69838))

* **cli:** fix the removal of type definitions by `export-dynamic`. ([janus-idp#1810](janus-idp#1810)) ([8472d91](janus-idp@8472d91))
* **feedback:** fixed feedback backend plugin crashing ([janus-idp#1809](janus-idp#1809)) ([e4a571e](janus-idp@e4a571e))
* **feedback:** update EntityPage component ([janus-idp#1798](janus-idp#1798)) ([f5b04b5](janus-idp@f5b04b5))
* **kiali:** fix dev links ([janus-idp#1801](janus-idp#1801)) ([2a86a5e](janus-idp@2a86a5e))
* **kiali:** remove debug window ([janus-idp#1793](janus-idp#1793)) ([b5b5376](janus-idp@b5b5376))
* **kiali:** sanitize input for CWE-79 ([janus-idp#1786](janus-idp#1786)) ([9ba95bb](janus-idp@9ba95bb))
* missing postversion script is several plugins and missing turbo dependency ([janus-idp#1811](janus-idp#1811)) ([4dfe4f5](janus-idp@4dfe4f5))
* **orchestrator:** fix error handling in case data index failed to start ([janus-idp#1804](janus-idp#1804)) ([27affb7](janus-idp@27affb7))
* **topology:** remove check for catalog entity permission ([janus-idp#1800](janus-idp#1800)) ([fd6ae41](janus-idp@fd6ae41))

* **kiali:** update development doc for alpha backend([janus-idp#1720](janus-idp#1720)) ([e06e9be](janus-idp@e06e9be))
* **rbac:** add type checks with generics for audit log ([janus-idp#1789](janus-idp#1789)) ([ac69838](janus-idp@ac69838))
* switch defaults of the `--embed-as-dependencies` and `in-place` options. ([janus-idp#1787](janus-idp#1787)) ([049e675](janus-idp@049e675))

* **cli:** fix the removal of type definitions by `export-dynamic`. ([janus-idp#1810](janus-idp#1810)) ([8472d91](janus-idp@8472d91))
* **feedback:** fixed feedback backend plugin crashing ([janus-idp#1809](janus-idp#1809)) ([e4a571e](janus-idp@e4a571e))
* **feedback:** update EntityPage component ([janus-idp#1798](janus-idp#1798)) ([f5b04b5](janus-idp@f5b04b5))
* **kiali:** fix dev links ([janus-idp#1801](janus-idp#1801)) ([2a86a5e](janus-idp@2a86a5e))
* **kiali:** remove debug window ([janus-idp#1793](janus-idp#1793)) ([b5b5376](janus-idp@b5b5376))
* **kiali:** sanitize input for CWE-79 ([janus-idp#1786](janus-idp#1786)) ([9ba95bb](janus-idp@9ba95bb))
* missing postversion script is several plugins and missing turbo dependency ([janus-idp#1811](janus-idp#1811)) ([4dfe4f5](janus-idp@4dfe4f5))
* **orchestrator:** fix error handling in case data index failed to start ([janus-idp#1804](janus-idp#1804)) ([27affb7](janus-idp@27affb7))
* **topology:** remove check for catalog entity permission ([janus-idp#1800](janus-idp#1800)) ([fd6ae41](janus-idp@fd6ae41))

* **kiali:** update development doc for alpha backend([janus-idp#1720](janus-idp#1720)) ([e06e9be](janus-idp@e06e9be))
* **rbac:** add type checks with generics for audit log ([janus-idp#1789](janus-idp#1789)) ([ac69838](janus-idp@ac69838))

* **cli:** fix the removal of type definitions by `export-dynamic`. ([janus-idp#1810](janus-idp#1810)) ([8472d91](janus-idp@8472d91))
* **feedback:** fixed feedback backend plugin crashing ([janus-idp#1809](janus-idp#1809)) ([e4a571e](janus-idp@e4a571e))
* **feedback:** update EntityPage component ([janus-idp#1798](janus-idp#1798)) ([f5b04b5](janus-idp@f5b04b5))
* **kiali:** fix dev links ([janus-idp#1801](janus-idp#1801)) ([2a86a5e](janus-idp@2a86a5e))
* **kiali:** remove debug window ([janus-idp#1793](janus-idp#1793)) ([b5b5376](janus-idp@b5b5376))
* **kiali:** sanitize input for CWE-79 ([janus-idp#1786](janus-idp#1786)) ([9ba95bb](janus-idp@9ba95bb))
* missing postversion script is several plugins and missing turbo dependency ([janus-idp#1811](janus-idp#1811)) ([4dfe4f5](janus-idp@4dfe4f5))
* **orchestrator:** fix error handling in case data index failed to start ([janus-idp#1804](janus-idp#1804)) ([27affb7](janus-idp@27affb7))
* **topology:** remove check for catalog entity permission ([janus-idp#1800](janus-idp#1800)) ([fd6ae41](janus-idp@fd6ae41))

* **kiali:** update development doc for alpha backend([janus-idp#1720](janus-idp#1720)) ([e06e9be](janus-idp@e06e9be))
* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))

* **audit-log:** deep copy objects passed into audit logger so redactor will not modify objects and remove `auditErrorLog` function ([janus-idp#1730](janus-idp#1730)) ([379c241](janus-idp@379c241))
* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **rbac:** add support for scaling ([janus-idp#1757](janus-idp#1757)) ([caddc83](janus-idp@caddc83))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** fix role list view permission policies column value ([janus-idp#1714](janus-idp#1714)) ([07200e4](janus-idp@07200e4))
* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))

* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))

* **audit-log:** deep copy objects passed into audit logger so redactor will not modify objects and remove `auditErrorLog` function ([janus-idp#1730](janus-idp#1730)) ([379c241](janus-idp@379c241))
* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **rbac:** add support for scaling ([janus-idp#1757](janus-idp#1757)) ([caddc83](janus-idp@caddc83))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** fix role list view permission policies column value ([janus-idp#1714](janus-idp#1714)) ([07200e4](janus-idp@07200e4))
* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))

* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **rbac:** add support for scaling ([janus-idp#1757](janus-idp#1757)) ([caddc83](janus-idp@caddc83))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** fix role list view permission policies column value ([janus-idp#1714](janus-idp#1714)) ([07200e4](janus-idp@07200e4))
* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))

* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **rbac:** add support for scaling ([janus-idp#1757](janus-idp#1757)) ([caddc83](janus-idp@caddc83))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** fix role list view permission policies column value ([janus-idp#1714](janus-idp#1714)) ([07200e4](janus-idp@07200e4))
@kim-tsao kim-tsao requested a review from a team as a code owner October 8, 2024 21:32
@openshift-ci openshift-ci bot requested a review from schultzp2020 October 8, 2024 21:33
@kim-tsao kim-tsao changed the title chore(deps): Rebase 1.2.x plugins to their latest patch versions chore(deps): rebase 1.2.x plugins to their latest patch versions Oct 8, 2024
Copy link

sonarqubecloud bot commented Oct 9, 2024

rm3l

This comment was marked as off-topic.

@rm3l
Copy link
Member

rm3l commented Oct 9, 2024

Whoops - sorry for the noise. I commented on the wrong PR 🤦🏿

@PatAKnight
Copy link
Member

Looks good to me. Most of it was just updating to the LoggerService. I am going to wait to give an approval in case any of the other teams that are impacted want to take a look as well.

Copy link
Member

@yashoswalyo yashoswalyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mareklibra
Copy link
Contributor

LGTM - orchestrator

@batzionb
Copy link
Contributor

batzionb commented Oct 9, 2024

/lgtm

Copy link
Member

@PatAKnight PatAKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@nickboldt nickboldt merged commit b3ca316 into janus-idp:1.2.x Oct 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.