Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch defaults of the --embed-as-dependencies and in-place options. #1787

Merged
merged 2 commits into from
Jun 5, 2024
Merged

feat: switch defaults of the --embed-as-dependencies and in-place options. #1787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65678b6
feat: switch defaults of the `--embed-as-dependencies` and `in-place`…
davidfestal Jun 5, 2024
4f499e5
chore: update dirty yarn.lock
davidfestal Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/cli/src/commands/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,16 +123,16 @@ export function registerScriptCommand(program: Command) {
)
.option(
'--embed-as-dependencies',
'Include embedded packages as private dependencies of backend plugins, instead of merging them with the generated code. Experimental for now, but expected to become the default.',
false,
'Include embedded packages as private dependencies of backend plugins. When value is `false` (using `--no-embed-as-dependencies`), source code of embedded plugins is merged with the generated code, so that the embedded plugin packages are completly erased (only available for legacy reasons: use with care).',
true,
)
.option('--no-embed-as-dependencies', undefined, true)
.option('--no-embed-as-dependencies', undefined, false)
.option(
'--in-place',
'Adds the frontend dynamic plugin assets to the `dist-scalprum` folder of the original plugin package. When value is `false` (using `--no-in-place`), it produces the assets in a distinct package located in the `dist-dynamic` sub-folder, as for backend plugins. `true` by default for now, it is expected to become `false` by default.',
true,
'Adds the frontend dynamic plugin assets to the `dist-scalprum` folder of the original plugin package, instead of producing the assets in a distinct package located in the `dist-dynamic` sub-folder, as for backend plugins.',
false,
)
.option('--no-in-place', undefined, false)
.option('--no-in-place', undefined, true)
.option(
'--scalprum-config <file>',
'Allows retrieving scalprum configuration from an external JSON file, instead of using a `scalprum` field of the `package.json`. Frontend plugins only.',
Expand Down
12 changes: 0 additions & 12 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6307,18 +6307,6 @@
yml-loader "^2.1.0"
yn "^4.0.0"

"@janus-idp/[email protected]":
version "2.6.3"
resolved "https://registry.npmjs.org/@janus-idp/shared-react/-/shared-react-2.6.3.tgz#de98b434d19b96197f053095e0c412e3eabc1155"
integrity sha512-kQzY4+WXTtArAy9breW7PuWonlT6GbgZEEA+oClkOY5ETl9AW7QKgymNHSdemkIZrx+qJro/xF2yt70skIrBdg==
dependencies:
"@kubernetes/client-node" "^0.20.0"
classnames "^2.3.2"
date-fns "^2.30.0"
file-saver "^2.0.5"
lodash "^4.17.21"
mathjs "^11.11.2"

"@jest/console@^29.7.0":
version "29.7.0"
resolved "https://registry.yarnpkg.com/@jest/console/-/console-29.7.0.tgz#cd4822dbdb84529265c5a2bdb529a3c9cc950ffc"
Expand Down
Loading