fix(regex-actions): fix #594: Cleanup some small code smells

[christoph-jerolimov]

Fix #594: Cleanup 3 small code smells reported by sonarcloud:

• https://sonarcloud.io/code?id=janus-idp_backstage-plugins&selected=janus-idp_backstage-plugins%3Aplugins%2Fregex-actions%2Fsrc%2Factions%2Fregex%2Freplace.ts
  • removed the FIXME: comments since the common input format is YAML which doesn't support Sets. So imho it might be incorrect to expect a Set here.
  • Updated the README with the right Type definition.
  • fixed another warning that recommended to prefer startsWith and endsWith.
• https://sonarcloud.io/code?id=janus-idp_backstage-plugins&selected=janus-idp_backstage-plugins%3Aplugins%2Fregex-actions%2Fsrc%2Factions%2Fregex%2Freplace.test.ts
  • fixed type casting to Writable

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

[gashcrumb]

👍