Skip to content

Commit

Permalink
fix(cli): completely removing the requirement for app-config when e…
Browse files Browse the repository at this point in the history
…xporting fronted plugins to dynamic. (#1603)

Signed-off-by: David Festal <[email protected]>
  • Loading branch information
davidfestal authored May 2, 2024
1 parent 8acd221 commit 7fb243a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,6 @@ export async function frontend(
...scalprum,
version,
},
fromPackage: name,
resolvedScalprumDistPath,
});

Expand Down
9 changes: 1 addition & 8 deletions packages/cli/src/lib/builder/buildScalprumPlugin.ts
Original file line number Diff line number Diff line change
@@ -1,30 +1,23 @@
import { PluginBuildMetadata } from '@openshift/dynamic-plugin-sdk-webpack';

import { buildScalprumBundle } from '../bundler/bundlePlugin';
import { loadCliConfig } from '../config';
import { getEnvironmentParallelism } from '../parallel';

interface BuildScalprumPluginOptions {
targetDir: string;
writeStats: boolean;
configPaths: string[];
pluginMetadata: PluginBuildMetadata;
fromPackage: string;
resolvedScalprumDistPath: string;
}

export async function buildScalprumPlugin(options: BuildScalprumPluginOptions) {
const { targetDir, pluginMetadata, fromPackage, resolvedScalprumDistPath } =
options;
const { targetDir, pluginMetadata, resolvedScalprumDistPath } = options;
await buildScalprumBundle({
targetDir,
entry: 'src/index',
parallelism: getEnvironmentParallelism(),
pluginMetadata,
...(await loadCliConfig({
args: [],
fromPackage,
})),
resolvedScalprumDistPath,
});
}

0 comments on commit 7fb243a

Please sign in to comment.