feat(rbac): role overview (#972)

janus-idp · Dec 5, 2023 · 43c1906 · 43c1906
1 parent e4e1364
commit 43c1906
Show file tree

Hide file tree

Showing 33 changed files with 2,348 additions and 157 deletions.
diff --git a/plugins/rbac-common/src/types.ts b/plugins/rbac-common/src/types.ts
@@ -17,3 +17,8 @@ export type UpdatePolicy = {
   oldPolicy: Policy;
   newPolicy: Policy;
 };
+
+export type PermissionPolicy = {
+  pluginId?: string;
+  policies?: Policy[];
+};
diff --git a/plugins/rbac/dev/index.tsx b/plugins/rbac/dev/index.tsx
@@ -7,10 +7,19 @@ import {
 } from '@backstage/plugin-permission-react';
 import { TestApiProvider } from '@backstage/test-utils';
 
-import { Role, RoleBasedPolicy } from '@janus-idp/backstage-plugin-rbac-common';
+import {
+  PermissionPolicy,
+  Policy,
+  Role,
+  RoleBasedPolicy,
+} from '@janus-idp/backstage-plugin-rbac-common';
 
+import { mockMembers } from '../src/__fixtures__/mockMembers';
+import { mockPermissionPolicies } from '../src/__fixtures__/mockPermissionPolicies';
+import { mockPolicies } from '../src/__fixtures__/mockPolicies';
 import { RBACAPI, rbacApiRef } from '../src/api/RBACBackendClient';
 import { RbacPage, rbacPlugin } from '../src/plugin';
+import { MemberEntity } from '../src/types';
 
 class MockPermissionApi implements PermissionApi {
   readonly result;
@@ -34,80 +43,7 @@ class MockRBACApi implements RBACAPI {
     return this.resources;
   }
   async getPolicies(): Promise<RoleBasedPolicy[]> {
-    return [
-      {
-        entityReference: 'role:default/guests',
-        permission: 'catalog-entity',
-        policy: 'read',
-        effect: 'deny',
-      },
-      {
-        entityReference: 'role:default/guests',
-        permission: 'catalog.entity.create',
-        policy: 'use',
-        effect: 'deny',
-      },
-      {
-        entityReference: 'role:default/guests',
-        permission: 'catalog-entity',
-        policy: 'read',
-        effect: 'allow',
-      },
-      {
-        entityReference: 'role:default/guests',
-        permission: 'catalog.entity.create',
-        policy: 'use',
-        effect: 'allow',
-      },
-      {
-        entityReference: 'role:default/guests',
-        permission: 'policy-entity',
-        policy: 'create',
-        effect: 'allow',
-      },
-      {
-        entityReference: 'role:default/guests',
-        permission: 'policy-entity',
-        policy: 'read',
-        effect: 'allow',
-      },
-      {
-        entityReference: 'role:default/guests',
-        permission: 'policy.entity.read',
-        policy: 'use',
-        effect: 'allow',
-      },
-      {
-        entityReference: 'role:default/guests',
-        permission: 'policy-entity',
-        policy: 'delete',
-        effect: 'allow',
-      },
-      {
-        entityReference: 'role:default/rbac_admin',
-        permission: 'policy-entity',
-        policy: 'read',
-        effect: 'allow',
-      },
-      {
-        entityReference: 'role:default/rbac_admin',
-        permission: 'policy-entity',
-        policy: 'create',
-        effect: 'allow',
-      },
-      {
-        entityReference: 'role:default/rbac_admin',
-        permission: 'policy-entity',
-        policy: 'delete',
-        effect: 'allow',
-      },
-      {
-        entityReference: 'role:default/rbac_admin',
-        permission: 'policy-entity',
-        policy: 'update',
-        effect: 'allow',
-      },
-    ];
+    return mockPolicies;
   }
 
   async getUserAuthorization(): Promise<{ status: string }> {
@@ -116,9 +52,30 @@ class MockRBACApi implements RBACAPI {
     };
   }
 
+  async getRole(role: string): Promise<Role[]> {
+    const roleresource = this.resources.find(res => res.name === role);
+    return roleresource ? [roleresource] : [];
+  }
+
   async deleteRole(_roleName: string): Promise<any> {
     return { status: 204 };
   }
+
+  async getMembers(): Promise<MemberEntity[]> {
+    return mockMembers;
+  }
+
+  async listPermissions(): Promise<PermissionPolicy[]> {
+    return mockPermissionPolicies;
+  }
+
+  async deletePolicy(
+    _entityRef: string,
+    _permission: string,
+    _policies: Policy[],
+  ): Promise<number> {
+    return 204;
+  }
 }
 
 const mockPermissionApi = new MockPermissionApi({ result: 'ALLOW' });

diff --git a/plugins/rbac/package.json b/plugins/rbac/package.json
@@ -28,6 +28,7 @@
     "@backstage/catalog-model": "^1.4.3",
     "@backstage/core-components": "^0.13.6",
     "@backstage/core-plugin-api": "^1.7.0",
+    "@backstage/plugin-catalog": "^1.15.1",
     "@backstage/plugin-permission-react": "^0.4.16",
     "@backstage/theme": "^0.4.3",
     "@janus-idp/backstage-plugin-rbac-common": "1.1.0",
@@ -36,10 +37,12 @@
     "@material-ui/lab": "^4.0.0-alpha.45",
     "@mui/icons-material": "5.14.11",
     "@mui/material": "^5.14.18",
-    "react-use": "^17.4.0"
+    "react-use": "^17.4.0",
+    "lodash": "^4.17.21"
   },
   "peerDependencies": {
-    "react": "^16.13.1 || ^17.0.0"
+    "react": "^16.13.1 || ^17.0.0",
+    "react-router-dom": "^6.20.0"
   },
   "devDependencies": {
     "@backstage/cli": "0.23.0",
@@ -49,6 +52,7 @@
     "@janus-idp/cli": "1.4.6",
     "@testing-library/jest-dom": "5.17.0",
     "@testing-library/react": "12.1.5",
+    "@testing-library/react-hooks": "8.0.1",
     "@testing-library/user-event": "14.5.1",
     "@types/node": "18.18.5",
     "msw": "1.3.2"