chore(deps): change deps to peer deps in common packages (#2404)

* chore(deps): change deps to peer deps in common packages Signed-off-by: Paul Schultz <[email protected]> * fix dep Signed-off-by: Paul Schultz <[email protected]> --------- Signed-off-by: Paul Schultz <[email protected]>
janus-idp · Oct 18, 2024 · 2bebc8c · 2bebc8c
1 parent 59374c5
commit 2bebc8c
Show file tree

Hide file tree

Showing 11 changed files with 30 additions and 19 deletions.
diff --git a/.changeset/perfect-ways-marry.md b/.changeset/perfect-ways-marry.md
@@ -0,0 +1,12 @@
+---
+"@janus-idp/backstage-plugin-orchestrator-common": patch
+"@janus-idp/backstage-plugin-bulk-import-common": patch
+"@janus-idp/backstage-plugin-topology-common": patch
+"@janus-idp/backstage-plugin-tekton-common": patch
+"@janus-idp/backstage-plugin-ocm-backend": patch
+"@janus-idp/backstage-plugin-quay-common": patch
+"@janus-idp/backstage-plugin-rbac-common": patch
+"@janus-idp/backstage-plugin-ocm-common": patch
+---
+
+change deps to peer deps in common packages
diff --git a/plugins/bulk-import-common/package.json b/plugins/bulk-import-common/package.json
@@ -39,7 +39,7 @@
     "prettier": "3.3.3",
     "@backstage/cli": "0.27.1"
   },
-  "dependencies": {
+  "peerDependencies": {
     "@backstage/plugin-permission-common": "^0.8.1"
   },
   "files": [

diff --git a/plugins/ocm-backend/package.json b/plugins/ocm-backend/package.json
@@ -31,8 +31,8 @@
   "scripts": {
     "build": "backstage-cli package build",
     "clean": "backstage-cli package clean",
-    "export-dynamic": "janus-cli package export-dynamic-plugin --embed-package --embed-package @backstage/plugin-kubernetes-common",
-    "export-dynamic:clean": "janus-cli package export-dynamic-plugin --embed-package --embed-package @backstage/plugin-kubernetes-common --clean",
+    "export-dynamic": "janus-cli package export-dynamic-plugin --embed-package @backstage/plugin-kubernetes-common",
+    "export-dynamic:clean": "janus-cli package export-dynamic-plugin --embed-package @backstage/plugin-kubernetes-common --clean",
     "lint:check": "backstage-cli package lint",
     "lint:fix": "backstage-cli package lint --fix",
     "postpack": "backstage-cli package postpack",

diff --git a/plugins/ocm-common/package.json b/plugins/ocm-common/package.json
@@ -54,7 +54,7 @@
   ],
   "homepage": "https://red.ht/rhdh",
   "bugs": "https://github.com/janus-idp/backstage-plugins/issues",
-  "dependencies": {
+  "peerDependencies": {
     "@backstage/plugin-permission-common": "^0.8.1"
   },
   "maintainers": [

diff --git a/plugins/orchestrator-common/package.json b/plugins/orchestrator-common/package.json
@@ -57,19 +57,20 @@
     "openapi:check": "./scripts/openapi.sh check",
     "openapi:prettier:fix": "prettier --ignore-unknown --write ./src/generated/api"
   },
-  "dependencies": {
-    "@backstage/types": "^1.1.1",
+  "peerDependencies": {
     "@backstage/plugin-permission-common": "^0.8.1",
     "@severlessworkflow/sdk-typescript": "^3.0.3",
     "js-yaml": "^4.1.0",
-    "json-schema": "^0.4.0",
     "axios": "^1.7.4"
   },
   "devDependencies": {
     "prettier": "3.3.3",
     "@backstage/cli": "0.27.1",
+    "@backstage/types": "1.1.1",
+    "json-schema": "0.4.0",
     "@openapitools/openapi-generator-cli": "2.13.4",
-    "js-yaml-cli": "0.6.0"
+    "js-yaml-cli": "0.6.0",
+    "@severlessworkflow/sdk-typescript": "3.0.3"
   },
   "maintainers": [
     "@janus-idp/maintainers-plugins",

diff --git a/plugins/orchestrator-common/src/types.ts b/plugins/orchestrator-common/src/types.ts
@@ -1,9 +1,9 @@
-import { JsonObject } from '@backstage/types';
+import type { JsonObject } from '@backstage/types';
 
-import { Specification } from '@severlessworkflow/sdk-typescript';
-import { JSONSchema7, JSONSchema7Definition } from 'json-schema';
+import type { Specification } from '@severlessworkflow/sdk-typescript';
+import type { JSONSchema7, JSONSchema7Definition } from 'json-schema';
 
-import { ProcessInstance, ProcessInstanceStateValues } from './models';
+import type { ProcessInstance, ProcessInstanceStateValues } from './models';
 
 type Id<T> = { [P in keyof T]: T[P] };
 

diff --git a/plugins/quay-common/package.json b/plugins/quay-common/package.json
@@ -53,10 +53,8 @@
   "files": [
     "dist"
   ],
-  "dependencies": {
-    "@backstage/plugin-permission-common": "^0.8.1"
-  },
   "peerDependencies": {
+    "@backstage/plugin-permission-common": "^0.8.1",
     "react": "16.13.1 || ^17.0.0 || ^18.0.0"
   },
   "devDependencies": {

diff --git a/plugins/rbac-common/package.json b/plugins/rbac-common/package.json
@@ -35,7 +35,7 @@
     "prepack": "backstage-cli package prepack",
     "postpack": "backstage-cli package postpack"
   },
-  "dependencies": {
+  "peerDependencies": {
     "@backstage/plugin-permission-common": "^0.8.1",
     "@backstage/errors": "^1.2.4"
   },

diff --git a/plugins/tekton-common/package.json b/plugins/tekton-common/package.json
@@ -33,7 +33,7 @@
     "prettier:check": "prettier --ignore-unknown --check .",
     "prettier:fix": "prettier --ignore-unknown --write ."
   },
-  "dependencies": {
+  "peerDependencies": {
     "@backstage/plugin-permission-common": "^0.8.1"
   },
   "devDependencies": {

diff --git a/plugins/topology-common/package.json b/plugins/topology-common/package.json
@@ -53,7 +53,7 @@
   ],
   "homepage": "https://red.ht/rhdh",
   "bugs": "https://github.com/janus-idp/backstage-plugins/issues",
-  "dependencies": {
+  "peerDependencies": {
     "@backstage/plugin-permission-common": "^0.8.1"
   },
   "maintainers": [

diff --git a/yarn.lock b/yarn.lock