Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xhtml option to make link tags self-closing #255

Merged
merged 2 commits into from
Mar 15, 2016

Conversation

koenpunt
Copy link
Contributor

Some apps require xhtml tags to be generated (like here webpack-contrib/extract-text-webpack-plugin#160)

@jantimon
Copy link
Owner

Could you please add a note to the readme and a unit test?

@koenpunt
Copy link
Contributor Author

🚀

@jantimon
Copy link
Owner

Just thinking - would selfClosingTags be better than just xml ?

@koenpunt
Copy link
Contributor Author

xhtml could be more than just closing tags. Maybe eventually there are some required attributes on tags in xhtml, which are not necessary for just html

@jantimon
Copy link
Owner

True but this wouldn't be backwards compatible if we extend xml later on.

@koenpunt
Copy link
Contributor Author

this wouldn't be backwards compatible

In what way backwards compatible?

extend xml later on

You're planning on xml support? How does that work? And in terms of naming, then the package name would be incorrect too I guess.

@jantimon
Copy link
Owner

You said you might want to extend the xml feature set for the xml option eventually in future.
This would probably break backwards compatibility for people who set xml to true to get the self closing tags.

@koenpunt
Copy link
Contributor Author

I didn't mention xml, only xhtml

@jantimon
Copy link
Owner

Sorry for the confusion I meant xhtml.

@koenpunt
Copy link
Contributor Author

Setting xhtml to true would mean you expect the output to be XHTML compliant, so as long as that's what is does, there won't be any backward incompatibilities later on.
selfClosingTags would imply there are other reason than being XHTML compliant for self-closing tags to be present.

@jantimon
Copy link
Owner

Not complete sold but sounds okay

@jantimon jantimon closed this Mar 15, 2016
@jantimon jantimon reopened this Mar 15, 2016
jantimon added a commit that referenced this pull request Mar 15, 2016
Add xhtml option to make link tags self-closing
@jantimon jantimon merged commit b613824 into jantimon:master Mar 15, 2016
@koenpunt koenpunt deleted the xhtml branch March 15, 2016 14:24
@koenpunt koenpunt restored the xhtml branch March 15, 2016 14:26
@koenpunt
Copy link
Contributor Author

Cool, could you release a new version of the package? Thanks!

@lock
Copy link

lock bot commented May 31, 2018

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 31, 2018
@koenpunt koenpunt deleted the xhtml branch May 31, 2018 13:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants