Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't add extra meta tag if it exists #1802

Merged
merged 1 commit into from
Jun 10, 2023
Merged

Conversation

alexander-akait
Copy link
Collaborator

fixes #1387

@@ -76,7 +76,8 @@ class HtmlWebpackPlugin {
// Default metaOptions if no template is provided
if (!userOptions.template && options.templateContent === false && options.meta) {
const defaultMeta = {
// From https://developer.mozilla.org/en-US/docs/Mozilla/Mobile/Viewport_meta_tag
// TODO remove in the next major release
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should avoid to add any meta tags in the next major release, we can provide a good default HTML template, it should be inside template or we should fully parse HTML document and check if we already have duplications

@alexander-akait alexander-akait merged commit 8f92788 into main Jun 10, 2023
@alexander-akait alexander-akait deleted the issue-1387 branch June 10, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An extra ‘viewport’ meta with default template 'src/index.ejs'
1 participant