Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require.ensure modules are inserted into html. #95

Closed
shlomiassaf opened this issue Oct 7, 2015 · 5 comments
Closed

require.ensure modules are inserted into html. #95

shlomiassaf opened this issue Oct 7, 2015 · 5 comments

Comments

@shlomiassaf
Copy link

Since require.ensure modules are implicitly declared async modules they should not appear in the final html.
@jantimon
Copy link
Owner

jantimon commented Oct 7, 2015

Absolutely - could you please open a pull request?

@shlomiassaf
Copy link
Author

I will, but before that...

Does webpack give any insight on the assets type, meaning sync or async?

I didnt find any reference to it, so it might not be possible...
A workaround is already supported via ignores..

@vyorkin
Copy link
Contributor

vyorkin commented Nov 10, 2015

its chunk.initial, I'll submit a PR

@vyorkin vyorkin mentioned this issue Nov 10, 2015
Merged
@jantimon
Copy link
Owner

Okay cool will merge it soon for both branches

sheerun added a commit to sheerun/webpack-split-by-path that referenced this issue Nov 28, 2015
@sheerun
Set initial = true for each of created chunks
57e704b 
According to jantimon/html-webpack-plugin#95 initial set
means that asset it synchronous (vs async).

This fix is needed to fix jantimon/html-webpack-plugin#127
@sheerun sheerun mentioned this issue Nov 28, 2015
Merged
@renovate renovate bot mentioned this issue Apr 17, 2018
Closed
@lock
Copy link

lock bot commented Jun 1, 2018

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vyorkin @jantimon @shlomiassaf