missing dependency (html-minifier)

[obartra]

Expected behaviour

Webpack build succeeds

Current behaviour

Webpack build fails, requiring "html-minifier" from "html-webpack-plugin"

ERR!   Error: Cannot find module 'html-minifier'
ERR!   Require stack:
ERR!   - /myproject/node_modules/html-webpack-plugin

Manually installing html-minifier fixes the issue

Environment

On [email protected], [email protected], [email protected], [email protected]

Config

NA

Relevant Links

NA

Additional context

I suspect adding html-minifier to html-webpack-plugin dependencies would fix the issue, happy to contribute if that's the desired change

[jantimon]

Thanks for the heads up 👍 will take a look

[jantimon]

Unfortunately I introduced this with #1309 - however all builds were green 🤔

[obartra]

My guess is that it's because html-loader is included as a dev dependency which installs it but it's not available by the package when published (only dependencies are).

You should be able to repro this issue if instead of npm ci or npm i you run npm i --production

[jantimon]

Hey @obartra

can you please verify that it works now?
[email protected]

[obartra]

I was using html-webpack-plugin through storybook so I don't have specific control on the version but regenerating the package-lock.json succeeds now without html-minifier as an explicit dependency so I think that did the trick!

Thanks so much for the quick response 🎉

[jantimon]

Thanks for your feedback 👍👍