Improve ptable_heatmap_plotly() colorscale kwarg
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates: - [github.com/psf/black: 22.1.0 → 22.3.0](psf/black@22.1.0...22.3.0) - [github.com/asottile/pyupgrade: v2.31.0 → v2.31.1](asottile/pyupgrade@v2.31.0...v2.31.1) - [github.com/pre-commit/mirrors-mypy: v0.931 → v0.942](pre-commit/mirrors-mypy@v0.931...v0.942) - [github.com/janosh/format-ipy-cells: v0.1.7 → v0.1.10](janosh/format-ipy-cells@v0.1.7...v0.1.10) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…cales and list of color strings
janosh
added a commit
that referenced
this pull request
Apr 6, 2022
* pre-commit set default_install_hook_types: [pre-commit, commit-msg] * ptable_heatmap_plotly colorscale kwarg support builtin plotly color scales and list of color strings * add test_ptable_heatmap_plotly_colorscale * readme update ptable_heatmap_plotly() previews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
colorscalenow supports builtin Plotly color scales and list of color strings. Plus more tests for all valid input types ofcolorscale: str | Sequence[str] | Sequence[tuple[float, str]] | None.Also sets more sensible defaults for color scale, font size, figure size and differentiates element symbols (now bold and large) better from heat map values.