Remove cumulative.py and associated tests + assets
#257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contained cumulative_error() and cumulative_residual() plotting functions
… table match the names in source files
janosh
added a commit
that referenced
this pull request
Dec 9, 2024
* remove cumulative.py and associated tests and assets contained cumulative_error() and cumulative_residual() plotting functions * move spacegroup_bar() assets into their own "Bar Plots" readme section * add test_readme_function_names that checks functions listed in readme table match the names in source files * remove local hook no-missing-readme-images
janosh
added a commit
that referenced
this pull request
Dec 11, 2024
* remove cumulative.py and associated tests and assets contained cumulative_error() and cumulative_residual() plotting functions * move spacegroup_bar() assets into their own "Bar Plots" readme section * add test_readme_function_names that checks functions listed in readme table match the names in source files * remove local hook no-missing-readme-images * include *.yml in pyproject.toml tool.setuptools.package-data (to have keys.yml in PyPI package)
janosh
added a commit
that referenced
this pull request
Dec 11, 2024
* remove cumulative.py and associated tests and assets contained cumulative_error() and cumulative_residual() plotting functions * move spacegroup_bar() assets into their own "Bar Plots" readme section * add test_readme_function_names that checks functions listed in readme table match the names in source files * remove local hook no-missing-readme-images * include *.yml in pyproject.toml tool.setuptools.package-data (to have keys.yml in PyPI package)
janosh
added a commit
that referenced
this pull request
Dec 11, 2024
* remove cumulative.py and associated tests and assets contained cumulative_error() and cumulative_residual() plotting functions * move spacegroup_bar() assets into their own "Bar Plots" readme section * add test_readme_function_names that checks functions listed in readme table match the names in source files * remove local hook no-missing-readme-images * include *.yml in pyproject.toml tool.setuptools.package-data (to have keys.yml in PyPI package)
janosh
added a commit
that referenced
this pull request
Dec 12, 2024
* remove cumulative.py and associated tests and assets contained cumulative_error() and cumulative_residual() plotting functions * move spacegroup_bar() assets into their own "Bar Plots" readme section * add test_readme_function_names that checks functions listed in readme table match the names in source files * remove local hook no-missing-readme-images * include *.yml in pyproject.toml tool.setuptools.package-data (to have keys.yml in PyPI package)
janosh
added a commit
that referenced
this pull request
Dec 12, 2024
* remove cumulative.py and associated tests and assets contained cumulative_error() and cumulative_residual() plotting functions * move spacegroup_bar() assets into their own "Bar Plots" readme section * add test_readme_function_names that checks functions listed in readme table match the names in source files * remove local hook no-missing-readme-images * include *.yml in pyproject.toml tool.setuptools.package-data (to have keys.yml in PyPI package)
janosh
added a commit
that referenced
this pull request
Dec 12, 2024
* remove cumulative.py and associated tests and assets contained cumulative_error() and cumulative_residual() plotting functions * move spacegroup_bar() assets into their own "Bar Plots" readme section * add test_readme_function_names that checks functions listed in readme table match the names in source files * remove local hook no-missing-readme-images * include *.yml in pyproject.toml tool.setuptools.package-data (to have keys.yml in PyPI package)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cumulative_error()andcumulative_residual()plotting functions no longer seem sufficiently versatile to keep. only rarely used them myself and have seen no external uses