Breaking: rename custom plotly template pymatviz_(black->dark)
#123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don't set px.defaults.template = "pymatviz_white", pio.templates.default = "pymatviz_white" when importing pymatviz (probably unwanted) copy plotly_white/dark before updating (no more modify in place)
for modifying HTML before writing to disk
for more information, see https://pre-commit.ci
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/code/tests/test_readme.py", line 3, in <module>
from pymatviz import ROOT
File "/code/pymatviz/__init__.py", line 16, in <module>
import matplotlib.pyplot as plt
ModuleNotFoundError: No module named 'matplotlib'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5e6717a breaking: rename custom plotly template
pymatviz_blacktopymatviz_dark83cf9a3 add
test_pkg_metadatabb13a38 add keyword
post_process: Callable[[str], str]todf_to_html_table()b17d6be make
file_pathoptional indf_to_html_table()and return HTML string04089c5 test return value in
test_df_to_html_tableand no file written iffile_path=None