Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slack notifications for new machines #74

Merged
merged 1 commit into from
Jul 23, 2023
Merged

Slack notifications for new machines #74

merged 1 commit into from
Jul 23, 2023

Conversation

jannisborn
Copy link
Owner

Fixes issue described in #70:

  • Comments and images that are posted for freshly added machines now also produce slack messages. Before the messages did not arrive although data was saved. It's achieved by reloading the server_locations.json at every comment/image posted. This takes ~2ms
  • I improved the structure of how comments are being saved per IP. It's now done in a nested directory like this: IP -> MachineID -> Date -> Text

@jannisborn jannisborn self-assigned this Jul 22, 2023
@jannisborn jannisborn requested a review from NinaWie July 22, 2023 09:35
@jannisborn jannisborn added the bug Something isn't working label Jul 22, 2023
@jannisborn
Copy link
Owner Author

New code is already in action on VM

@NinaWie
Copy link
Collaborator

NinaWie commented Jul 23, 2023

Thanks for fixing this! Looks good to me :)

@NinaWie NinaWie merged commit 54c3731 into main Jul 23, 2023
@NinaWie NinaWie deleted the comment_fix branch July 23, 2023 22:04
jannisborn added a commit that referenced this pull request Jul 31, 2023
@jannisborn
fix #70 (#74)
93fe18f
jannisborn added a commit that referenced this pull request Aug 2, 2023
@jannisborn @NinaWie
Data (#85)
b9dfe14 
* data: update colorado

* data: update colorado

* data: add machine in neusiedl

* multi wyom

* comments

* add two machines from emails and multimachine label

* add new machine in south dakota and retired machine

* graz machine

* data: retire utah

* data updates

* fix error in added machine which already existed

* fix #70 (#74)

* data

* data: update

* data: multimachine

---------

Co-authored-by: NinaWie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NinaWie NinaWie Awaiting requested review from NinaWie

Assignees

@jannisborn jannisborn

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jannisborn @NinaWie