OSM Machines #203
OSM Machines #203
Conversation
There was a problem hiding this comment.
Very cool!
One question: If we run the location differ now, and there is a new machine that matches with one of the elongated-coin machines, then the external_url would be replaced with the one from the pennycollector website, right? Because the elongated-coin machines are basically treated like the link = null machines?
Also, you should send me your vscode formatting settings; we should use the same because the format diff is very annoying.
backend/pennyme/osm.py
Outdated
| "properties": { | ||
| "name": title, | ||
| "active": True, | ||
| "area": country, |
There was a problem hiding this comment.
shouldn't this be "area": match
since you want to use the area from our list that was matched by fuzzysearch
|
@NinaWie exactly this was the idea to have the pennylocator website as the main data source. So if it's available it's preferred over elongated-coin website As for formatting, let's do this in a separate PR for all the backend code and set up a small CI routine, or even a pre-commit hoook with RUFF |
|
Makes sense, I agree to using the pennylocator website whenever available. Then it seems we can merge after resolving the server locations conflicts |
Adding ~450 new machines! Remaining 400 ones from OSM were processed and identified as already existing in our DB.
This PR will close #84
Some steps completed towards automatic OSM processing (#201 ) but more work required