Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sysdep/hasutmp{,x}addrv6.h-yes.c update test #69

Merged
merged 1 commit into from
Jul 17, 2022
Merged

Conversation

janmojzis
Copy link
Owner

detects if 'struct utmp{,x}' has '.ut_addr_v6' in compilation phase

detects if 'struct utmp{,x}' has '.ut_addr_v6' in compilation phase
@janmojzis
Copy link
Owner Author

I've updated the test.
Now it should work in cross-compilation.

Can You please @skarnet independently check this change?

@skarnet
Copy link
Contributor

skarnet commented Jul 16, 2022

Works for me in a native build. However, I don't have the time today to understand your cross-compilation scripts and set up a cross-build. I can try on Monday, but your change looks good to me and you can probably merge to master.

What I would really like is a way to force a sysdep to no (and also yes, if it's easily doable) without having to edit sysdep/list to comment the sysdeps I don't want.

My use case is that I want to build tinyssh against utmps, which is an implementation of utmpx; but the musl libc also provides a stub implementation of utmp, which I don't want to use, so I need to force the hasutmp sysdep (and related ones) to no, else my build fails. I'm currently doing it by editing sysdep/list but that's a hack and not easy to automate.

@janmojzis janmojzis merged commit 079e53e into master Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants