Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include typings in npm distribution #43

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Include typings in npm distribution #43

merged 1 commit into from
Jul 3, 2020

Conversation

FabianFrank
Copy link
Contributor

fixes #36

After this change you can see that npm includes the types:

$ npm pack
[...]
npm notice === Tarball Contents ===
npm notice 974B  package.json
npm notice 699B  jsonpointer.d.ts
npm notice 2.3kB jsonpointer.js
npm notice 1.2kB LICENSE.md
npm notice 1.3kB README.md
[...]

whereas before it wasn't.

@FabianFrank
Copy link
Contributor Author

@janl any chance that we can merge this?

@WesselKuipers WesselKuipers mentioned this pull request Aug 22, 2019
Merged
12 tasks
@reckter
Copy link
Contributor

reckter commented Apr 22, 2020

Hey, Is there any plan on merging this? typescript support would be awesome :)

@janl janl merged commit a4c6115 into janl:master Jul 3, 2020
@janl
Copy link
Owner

janl commented Jul 3, 2020

🎉 This PR is included in version 4.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@janl janl added the released label Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcbachmann marcbachmann marcbachmann approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does the typescript typings file work?
4 participants
@FabianFrank @reckter @janl @marcbachmann