Add analyze methods for getting metadata
#115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice to add fastimage as an analyzer as well. |
Besides processing images it would be nice to analyze images as well to get metadata like: width, height and rotation. This is currently based on the ActiveStorage::Analyzer::ImageAnalyzer.
p8
force-pushed
the
features/analyze
branch
from
d49df1c
to
2147bfe
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides processing images it would be nice to analyze images as well to get metadata like: width, height and rotation.
This is currently based on the ActiveStorage::Analyzer::ImageAnalyzer. I'd like to move that logic to ImageProcessing instead.
ActiveStorage currently logs if analyzing doesn't work, or if the image is invalid. Not sure if we should raise an error in
analyzeinstead, or maybe keep the image validation out of analyze.