"inherit" behavior is not being honored for boolean inputs

[nadiamoe]

Describe the bug

The documentation states that many boolean inputs (e.g. issues, issuesWoLabels, pullRequests, prWoLabels) default to the defaults of https://github.com/github-changelog-generator/github-changelog-generator. However, this is not currently the case.

The istrue helper will return false for empty variables, resulting in all ommited boolean parameters to default to false.

Reproduce

Use the action without specifying issues, issuesWoLabels, pullRequests and prWoLabels. It will generate an empty changelog.

Expected behavior

Boolean inputs should respect the defaults of https://github.com/github-changelog-generator/github-changelog-generator.

Additional context

This can be fixed by wrapping lines that use istrue

if istrue "$INPUT_ISSUES"; then ARG_ISSUES="--issues"; else ARG_ISSUES="--no-issues"; fi

with -n test as well:

if [[ -n $INPUT_ISSUES ]]; then if istrue "$INPUT_ISSUES"; then ARG_ISSUES="--issues"; else ARG_ISSUES="--no-issues"; fi; fi

[kamronbatman]

I personally prefer opt-in. This should be the default.

[boswelja]

Can we get an update on this? Either set defaults for inputs or fix the inherit behavior.

[janheinrichmerker]

Thanks @roobre, very good catch!
Indeed we should not pass options to Docker that were not specified in the action.
The default should always as closely as possible inherit the Docker image.