Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace shallowCopy with sink parameters #67

Merged
merged 2 commits into from
Aug 30, 2022
Merged

replace shallowCopy with sink parameters #67

merged 2 commits into from
Aug 30, 2022

Conversation

ringabout
Copy link
Contributor

Hello, shallowCopy has been removed for ARC/ORC since it does a deep copy with ARC/ORC → nim-lang/Nim#20070

ref nim-lang/Nim#19972

@ringabout ringabout mentioned this pull request Aug 30, 2022
Merged
@jangko
Copy link
Owner

jangko commented Aug 30, 2022

looks like nil usage also need to be fixed

@ringabout
Copy link
Contributor Author

looks like nil usage also need to be fixed

I checked. The failure is caused by nim-lang/Nim#20222

@jangko jangko merged commit 2422dfd into jangko:master Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ringabout @jangko