Make num dependency optional
#45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sexplib pulls in a dependency on `num` which for most users is unnecessary. Those users that need `sexplib.num` to convert to and from `num` values have a dependency on `num` already, those who don't have no need for `num` in their dependency cone. Signed-off-by: Marek Kubica <[email protected]>
Leonidas-from-XIV
force-pushed
the
sexplib-num
branch
from
888d208 to
a51c466
Compare
github-iron
added
the
forwarded-to-js-devs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sexplib pulls in a dependency on
numwhich for most users is unnecessary. Those users that needsexplib.numto convert to and fromnumvalues have a dependency onnumalready (and thus it won't change anything for them), those who don't, have no need fornumin their dependency cone and don't need to havesexplib.num.Normally OPAM subpackages are preferred over optional packages, but in this case having
sexplib.numbe optional depending on the installation ofnumseems quite sensible.H/T to @emillon for pointing this out.