Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Achieve compatibility with ppxlib 0.22.0 #32

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

pitag-ha
Copy link

In ppxlib 0.22.0, the AST gets bumped to ocaml 4.12. This commit adapts to the compiler changes from 4.11 to 4.12: mainly, the introduction of injectivity to type declarations.

It would be good to merge this PR when ppxlib 0.22.0 gets released, which will be soon.

cc @NathanReb

@pitag-ha pitag-ha force-pushed the upgrade-ppxlib-0.22.0 branch from 291fd9b to 1d74479 Compare February 4, 2021 17:08
In ppxlib 0.22.0, the AST gets bumped to ocaml 4.12. This commit adapts
to the compiler changes from 4.11 to 4.12: mainly, the introduction of
injectivity to type declarations.

Signed-off-by: Sonja Heinze <[email protected]>
@pitag-ha pitag-ha force-pushed the upgrade-ppxlib-0.22.0 branch from 1d74479 to 26fa817 Compare February 4, 2021 17:12
@github-iron github-iron added the forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system. label Feb 5, 2021
@aalekseyev
Copy link
Contributor

cc @cwong-ocaml

@NathanReb
Copy link

ppxlib.0.22.0 has now been released!

@Kakadu
Copy link

Kakadu commented Feb 18, 2021

It would be great to merge this PR sooner then later :)

@cwong-ocaml cwong-ocaml merged commit 3609848 into janestreet:v0.14 Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants