Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] non-local data #173

Merged
merged 4 commits into from
Apr 15, 2024
Merged

Conversation

d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Mar 18, 2024

This PR adds support for storage on nonlocal file systems (e.g., s3, http). It's WIP until I figure out how to run tests.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 59.51%. Comparing base (32bce43) to head (b5030df).
Report is 476 commits behind head on dev/main.

❗ Current head b5030df differs from pull request most recent head a3201c3. Consider uploading reports for the commit a3201c3 to get more accurate results

Files Patch % Lines
dacapo/blockwise/segment_worker.py 0.00% 1 Missing ⚠️
dacapo/cli.py 0.00% 1 Missing ⚠️
...periments/datasplits/datasets/arrays/tiff_array.py 0.00% 1 Missing ⚠️
...ts/datasplits/datasets/arrays/tiff_array_config.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           dev/main     #173      +/-   ##
============================================
+ Coverage     58.85%   59.51%   +0.65%     
============================================
  Files           191      190       -1     
  Lines          6490     6336     -154     
============================================
- Hits           3820     3771      -49     
+ Misses         2670     2565     -105     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhoadesScholar rhoadesScholar changed the base branch from main to dev/main March 20, 2024 18:10
@mzouink
Copy link
Member

mzouink commented Apr 15, 2024

@d-v-b why you set that universal-pathlib should be < 1.0.0

@d-v-b
Copy link
Contributor Author

d-v-b commented Apr 15, 2024

@d-v-b why you set that universal-pathlib should be < 1.0.0

Presumably, 1.0.0 will contain breaking changes. But since universal-pathlib is pre-1.0, if they follow semver, then there could be lots of pre-1.0 breaking changes, so maybe this guard is conservative.

Copy link
Member

@mzouink mzouink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gtg, waiting for tests

@mzouink mzouink merged commit a7adab7 into janelia-cellmap:dev/main Apr 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants