Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build ios app on m1 devices version 2 #174

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

ivanjiang5628
Copy link

@ivanjiang5628 ivanjiang5628 commented Oct 29, 2024

Description

When building the iOS app on M1 Macs with Xcode 15, we encountered several issues:

  • Build failures related to react-native-webrtc integration
  • GoogleSignIn Build Failures
  • AppAuth Library Issues
  • File Descriptor Limits

Solution and Changes

  1. Updates react-native-webrtc to version 1.94.1
  2. Introduces a new build script to replace the dated react-native-xcode.sh to prevent EMFILE: too many open files error during the building process.
  3. Replaces @react-native-community/google-signin": "3.0.1 with "@react-native-google-signin/google-signin": "^8.0.0” to fix the GoogleSignIn Build Failures
  4. Replaces npm with yarn to resolve the legacy dependencies issues.
  5. Adds config settings for watchman.
  6. Updates Podfile for better compatibility.
  7. Bumps required dependencies versions.

Release Risk Assessment

Given that there are no immediate plans to submit a new iOS build for the Jitsi app, merging this PR into the master branch may not be necessary at the moment. The changes are primarily focused on improving the build process and do not directly impact the app's functionality or release process.

Demo Notes

QA and Smoke Testing

Steps to Reproduce

Fixed / Expected Behaviour

Other Considerations

  • Will this affect other parts of the app or views?
  • How can the success of this work be confirmed after release to production?
  • What QA have you already done?

Screenshots

Before

After

@ivanjiang5628 ivanjiang5628 force-pushed the build-ios-app-on-m1-devices-v2 branch from f0d08b4 to 117407d Compare October 29, 2024 23:46
@ivanjiang5628 ivanjiang5628 self-assigned this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant