[PAT-1383] Update iOS UI #166

kaeramirez · 2023-11-08T23:26:16Z

Description

Updates the iOS UI to fetch Jane appointment details (treatment, treatment duration, start at + end at times and practitioner name) from state

https://jira-jane.atlassian.net/browse/PAT-1383

Release Risk Assessment

Low-med risk since iOS is harder to test

Demo Notes

N/A

QA and Smoke Testing

Expected Behaviour

Book an appointment and start a call
Ensure users can see the treatment information on the left side panel and modal in the waiting area with without PHI in JWT
Smoke test major features
Test in TestFlight and test the web app version of Jitsi as changes were made

Other Considerations

Will this affect other parts of the app or views?

Both the iOS version and the web app version of Jitsi

How can the success of this work be confirmed after release to production?

Must test on production once it is deployed to UK pod and join the call using an iOS device and must smoke test web app version as well

What QA have you already done?

Build without error in xcode but unable to visually confirm changes. We need to add this PR to iOS release branch in order to properly QA it in TestFlight

Screenshots

Before

After

kaeramirez · 2023-11-09T23:44:15Z

react/features/jane-waiting-area/components/native/DialogBox.js

@@ -169,7 +172,10 @@ class DialogBox extends Component<DialogBoxProps> {
            const response = await checkRoomStatus(jwt);
            const remoteParticipantsStatuses
                = getRemoteParticipantsStatuses(response.participant_statuses, participantType);
+            const jitsiDetails = response ? response.jitsi_details : {};


For iOS app we need to explicitly fetch from room status API and set jitsi_details here

I remember fetching this in socketConnection.js. I'm assuming we had to do this again for native? just want to double check

Yes, we have to explicitly do this again for the iOS app to ensure native UI can display the appointment details.

The history is because of a socket.io-client incompatibility issue there's a WebView for socket connections (with the socketconnection component within the WebView) in the native iOS app, see L458 of DialogBox.js . Because of this setup the webview and iOS app have have 2 different stores and operates in different environments so we need to fetch room status API again for the iOS app UI.

This was one of the tricky things @ivanjiang5628 and I were discussing with this PR. Hope I got this explanation right

@kaeramirez Thank you!

bitghost2m

The changes make sense to me. Just have one minor question.

bitghost2m · 2023-11-14T20:46:13Z

react/features/jane-waiting-area/components/native/DialogBox.js

@@ -169,7 +172,10 @@ class DialogBox extends Component<DialogBoxProps> {
            const response = await checkRoomStatus(jwt);
            const remoteParticipantsStatuses
                = getRemoteParticipantsStatuses(response.participant_statuses, participantType);
+            const jitsiDetails = response ? response.jitsi_details : {};


I remember fetching this in socketConnection.js. I'm assuming we had to do this again for native? just want to double check

ivanjiang5628

👍 LGTM

…gbox component

…om falls back to polling.

ivanjiang5628 · 2023-11-20T17:11:24Z

We might also want to do a QA for the web app, given the changes to react/features/jane-waiting-area/components/SocketConnection.js and the refactoring of the overwriteLocalParticipantWithJitsiDetails action in this PR.

kaeramirez · 2023-11-20T18:19:18Z

Test Plan

QA iOS app on Testflight, ensure appointment details are visible and user names are visible

QA web app version on s5, ensure appointment details are visible and user names are visible

Test both builds with 2 types of Jane repo branches: master and test on a branch that removes PHI from JWT
Test major features

Browsers

Chrome
new build of iOS app on iPhone and iPad

Pass PR in GitHub / Mark Ready for Release in Jira

Mark as "Ready for Release"

* fix an ios app compilation error that occurred in Metro bundler due to an incorrect import of a web app component in the notifcation/middleware.js file. (#161) * [PAT-1383] Update iOS UI (#166) * Update iOS UI * Fetch room status for iOS * Fix lint issues * fix fix an issue when overwriting the local participant info in Dialogbox component * Fix lint errors * Remove local name check and ensure we always update user's name * prevent re-overwriting the local user information when the waiting room falls back to polling. --------- Co-authored-by: Ivan Jiang <[email protected]> --------- Co-authored-by: kaeramirez <[email protected]>

kaeramirez self-assigned this Nov 8, 2023

kaeramirez added the Risk - Med Medium risk of disruption to codebase or infrastructure. label Nov 8, 2023

kaeramirez force-pushed the pat-1383-update-ios-waiting-room-ui branch from 6fea956 to f7000af Compare November 9, 2023 16:59

kaeramirez added 2 commits November 9, 2023 14:11

Update iOS UI

9c5ad80

Fetch room status for iOS

d7d2b23

kaeramirez force-pushed the pat-1383-update-ios-waiting-room-ui branch from f7000af to d7d2b23 Compare November 9, 2023 22:31

Fix lint issues

5f749dc

kaeramirez commented Nov 9, 2023

View reviewed changes

kaeramirez requested review from ivanjiang5628 and bitghost2m November 10, 2023 17:23

kaeramirez marked this pull request as ready for review November 10, 2023 17:23

bitghost2m reviewed Nov 14, 2023

View reviewed changes

ivanjiang5628 approved these changes Nov 14, 2023

View reviewed changes

bitghost2m approved these changes Nov 14, 2023

View reviewed changes

ivanjiang5628 and others added 2 commits November 16, 2023 09:42

fix fix an issue when overwriting the local participant info in Dialo…

98c5b13

…gbox component

Fix lint errors

14b58fb

kaeramirez force-pushed the pat-1383-update-ios-waiting-room-ui branch from b7f3237 to 14b58fb Compare November 16, 2023 18:18

ivanjiang5628 changed the base branch from master to ios-app-release-version-1.5.3-branch November 16, 2023 20:02

kaeramirez and others added 2 commits November 16, 2023 12:20

Remove local name check and ensure we always update user's name

95cd10f

prevent re-overwriting the local user information when the waiting ro…

a992614

…om falls back to polling.

ivanjiang5628 changed the base branch from ios-app-release-version-1.5.3-branch to master November 20, 2023 18:04

ivanjiang5628 changed the base branch from master to ios-app-release-version-1.5.3-branch November 20, 2023 18:07

ivanjiang5628 merged commit fc799c9 into ios-app-release-version-1.5.3-branch Nov 20, 2023
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PAT-1383] Update iOS UI #166

[PAT-1383] Update iOS UI #166

kaeramirez commented Nov 8, 2023 •

edited

Loading

kaeramirez Nov 9, 2023

bitghost2m Nov 14, 2023 •

edited

Loading

kaeramirez Nov 14, 2023

bitghost2m Nov 14, 2023

bitghost2m left a comment

bitghost2m Nov 14, 2023 •

edited

Loading

ivanjiang5628 left a comment

ivanjiang5628 commented Nov 20, 2023

kaeramirez commented Nov 20, 2023 •

edited

Loading

[PAT-1383] Update iOS UI #166

[PAT-1383] Update iOS UI #166

Conversation

kaeramirez commented Nov 8, 2023 • edited Loading

Description

Release Risk Assessment

Demo Notes

QA and Smoke Testing

Expected Behaviour

Other Considerations

Screenshots

Before

After

kaeramirez Nov 9, 2023

Choose a reason for hiding this comment

bitghost2m Nov 14, 2023 • edited Loading

Choose a reason for hiding this comment

kaeramirez Nov 14, 2023

Choose a reason for hiding this comment

bitghost2m Nov 14, 2023

Choose a reason for hiding this comment

bitghost2m left a comment

Choose a reason for hiding this comment

bitghost2m Nov 14, 2023 • edited Loading

Choose a reason for hiding this comment

ivanjiang5628 left a comment

Choose a reason for hiding this comment

ivanjiang5628 commented Nov 20, 2023

kaeramirez commented Nov 20, 2023 • edited Loading

Test Plan

Browsers

Pass PR in GitHub / Mark Ready for Release in Jira

kaeramirez commented Nov 8, 2023 •

edited

Loading

bitghost2m Nov 14, 2023 •

edited

Loading

bitghost2m Nov 14, 2023 •

edited

Loading

kaeramirez commented Nov 20, 2023 •

edited

Loading