Issue 702 contacts #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orbeckst
commented
Feb 25, 2016
orbeckst
commented
- put ContactAnalysis back in, it's not a beauty but we don't have 2D q1-q2 at the moment (needs some TLC... raise an issue if you care)
- doc strings all numpy (except for deprecated ContactAnalysis1 which will be scrapped anyway)
- numpy style docs - guard scipy.sparse import and warn - see PR MDAnalysis#708 for discussion
- ContactAnalysis was removed by @jandom but needs to stay because the functionality does not exist in the new Contact class (But it needs to be rewritten with AnalysisBase.) - updated doc strings (numpy style)
…o issue-702-contacts
|
Ping @jandom ... |
|
@orbeckst woops sorry, just saw that here |
|
All done here thank you @orbeckst |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.