fix: set gopath in makefile (argoproj#2398)

We currently assume that GOPATH is set within the developers environment go has some defaults that get used when no GOPATH is defined. If we use `go env GOPATH` to set the env var for the Makefile we will then also fall back to golang defaults which help contributior experiance. Signed-off-by: zachaller <[email protected]> Signed-off-by: zachaller <[email protected]>
jandersen-plaid · Nov 8, 2022 · e976ed5 · e976ed5
1 parent 621a34b
commit e976ed5
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/Makefile b/Makefile
@@ -23,6 +23,7 @@ E2E_INSTANCE_ID ?= argo-rollouts-e2e
 E2E_TEST_OPTIONS ?= 
 E2E_PARALLEL ?= 1
 E2E_WAIT_TIMEOUT ?= 120
+GOPATH ?= $(shell go env GOPATH)
 
 override LDFLAGS += \
   -X ${PACKAGE}/utils/version.version=${VERSION} \