Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes GEL more consumable as a C++ dependency via: cmake and definition as a nix package (flake) #62

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

kdmarrett
Copy link

Commented out the line: add_subdirectory(${glfw_SOURCE_DIR} ... since I could not figure out the purpose.

@janba
Copy link
Owner

janba commented Jun 28, 2023

Thanks a lot for working on ways to build GEL. On one hand, I think this is a great idea, but I am a little concerned about putting these nix files in the root directory. With the CMake build files I wonder if the stuff in GEL_UNIX is really needed anymore. Maybe that stuff could be cleaned out and the nix files could go there - possibly along with other package management build recipes?

@kdmarrett kdmarrett force-pushed the master branch 2 times, most recently from 03e4f30 to c2ea18c Compare July 2, 2023 00:17
@kdmarrett
Copy link
Author

kdmarrett commented Jul 2, 2023

I looked into the concern of polluting the git base directory with excessive *.nix files. It's best practice to keep the flake.nix and gel.nix files in the root directory so that they are directly findable by downstream librarires, and so users can install the library from the command line from the root directory of your project. The shell.nix files and default.nix aren't strictly necessary though and are for developer support for those who work with your library in a nix virtual environment--I could remove them. How would you like to proceed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants