Fix block on PING request #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes the indefinite hold of the lock following a PING message The _raw_recv and _mcon now respond to a PING message like all the other messages and will not block This blocking would prevent the bot from performing "send" (and other) requests until activity unblocked the bot This fix moves the PONG answer to the recv function where all the other messages processing takes place and returns the None event (no further processing required) Fixes jamieleshaw#33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the indefinite hold of the lock following a PING message
The _raw_recv and _mcon now respond to a PING message like all the other messages and will not block
This blocking would prevent the bot from performing "send" (and other) requests until activity unblocked the bot
This fix moves the PONG answer to the recv function where all the other messages processing takes place and returns the None event (no further processing required)
Fixes #33