Support react 17 peer dep

[bcomnes]

Geting peer dep warnings. Everything still works though.

[mtmacdonald]

Also requesting for this to be merged please!

[Hypnosphi]

@jamiebuilds can you please review

[sfcgeorge]

Since this is a polyfill it seems loosening the dependency to >= React 14 would be better. Even if React removes createContext again in a future version the polyfill would just start working again.

Currently with this overly strict dependency downstream projects like Reach Router (which uses create-react-context) and Storybook (which uses Reach) are failing to install using NPM v7 due to it now handling peerDependencies correctly.

[haysclark]

Since this is a polyfill it seems loosening the dependency to >= React 14 would be better. Even if React removes createContext again in a future version the polyfill would just start working again.

I believe that there is some wisdom behind being explicit, especially when it comes to JS dependencies (in this case "peerDependencies"); but I do agree it's rather subjective. 😉 My take-away from the React 17 release notes is that Facebook is preparing the community for API breaking changes coming in future versions of React. Knowing that future versions of React are not guaranteed to be backwards compatible, makes me lean away from the allure of >= React 14.

Just my two cents. ¯\(ツ)/¯

[haysclark]

Since this is a polyfill it seems loosening the dependency to >= React 14 would be better. Even if React removes createContext again in a future version the polyfill would just start working again.

My take-away from the React 17 release notes is that Facebook is preparing the community for API breaking changes coming in future versions of React. Knowing that future versions of React are not guaranteed to be backwards compatible, makes me lean away from the allure of >= React 14.

@sfcgeorge Actually, I think you are correct that >= React 14 would be better for this particular repo. The fact that this library is a polyfill completely changes my feeling towards its future compatibility and maintenance. It just took me a little time to catch up with your insight. :) TLDR; Re-reading your comment above, as well as your feedback in reach/router helped me understand your perspective. 👏

[bcomnes]

All good points, just going with what will make things work, and the existing pattern, though changing it to > 14 would be better.

[haysclark]

@jamiebuilds Merge? Feedback? 😄

[sfcgeorge]

Thanks @haysclark, there's good arguments both ways. @bcomnes is right, keeping most things the same is the easiest way to get something merged, and "done is better than perfect" ☺️

[haysclark]

still waiting for @jamiebuilds

[revmischa]

Please, I beg of you, merge this!
It breaks storybook with react 17 if you use npm v7, which catches these broken peer deps

Could not resolve dependency:
peer react@"^0.14.0 || ^15.0.0 || ^16.0.0" from [email protected]
node_modules/@reach/router/node_modules/create-react-context
  create-react-context@"0.3.0" from @reach/[email protected]
  node_modules/@reach/router
    @reach/router@"^1.3.3" from @storybook/[email protected]

[bcomnes]

I reached out to Jamie on Twitter a while back but did not receive a response. Would anyone be willing to launch and maintain a maintenance fork of this dependency and attempt to land it downstream to reach/storybook ?

[Hypnosphi]

I think I can

[Hypnosphi]

Forked to https://github.com/Hypnosphi/create-react-context & published as @hypnosphi/create-react-context

I used >= 0.14.0 per suggestion by @sfcgeorge

[bcomnes]

I am no longer interested in maintaining this pull request. If anyone wants to offer up another one here, feel free. I will be switching to @Hypnosphi's fork.