-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the warning package instead of fbjs #22
Conversation
Opened BerkeleyTrue/warning#30 to fix the bug in |
@jamiebuilds Could you merge this and make a new release? Thanks! 🙏 |
@jamiebuilds Please have a look at this PR |
Warning 4.0 has been fixed, I've updated the PR to use. @jamiebuilds Could you merge this & tag a new release? It'd help me remove fbjs from my dependencies. 🙏 |
Merged this at ant-design#1 and published as https://www.npmjs.com/package/@ant-design/create-react-context |
@jamiebuilds Hi. Please merge this PR |
@jamiebuilds, thanks! 🙏 |
Folks, this is an extreme long shot, but is there any chance of backporting this fix from |
React recently removed the dependency of fbjs (facebook/react#13069, not yet released). It's always been recommended that other packages shouldn't rely on it either.
At this point it'd pull in quite a bit of code so I simply exchanged it for the
warning
package.Note I had to use version 3 of
warning
as 4 seems to have a bug with additional arguments.