Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the warning package instead of fbjs #22

Merged
merged 1 commit into from
Jun 5, 2019
Merged

Use the warning package instead of fbjs #22

merged 1 commit into from
Jun 5, 2019

Conversation

realityking
Copy link
Contributor

React recently removed the dependency of fbjs (facebook/react#13069, not yet released). It's always been recommended that other packages shouldn't rely on it either.

At this point it'd pull in quite a bit of code so I simply exchanged it for the warning package.

Note I had to use version 3 of warning as 4 seems to have a bug with additional arguments.

@realityking
Copy link
Contributor Author

Opened BerkeleyTrue/warning#30 to fix the bug in warning.

@realityking
Copy link
Contributor Author

@jamiebuilds Could you merge this and make a new release? Thanks! 🙏

@realityking
Copy link
Contributor Author

@jamiebuilds Please have a look at this PR

@realityking
Copy link
Contributor Author

Warning 4.0 has been fixed, I've updated the PR to use.

@jamiebuilds Could you merge this & tag a new release? It'd help me remove fbjs from my dependencies. 🙏

@afc163
Copy link

afc163 commented Apr 16, 2019

Merged this at ant-design#1 and published as https://www.npmjs.com/package/@ant-design/create-react-context

@popuguytheparrot
Copy link

@jamiebuilds Hi. Please merge this PR

@jamiebuilds jamiebuilds merged commit b04abbb into jamiebuilds:master Jun 5, 2019
@realityking realityking deleted the warning branch June 5, 2019 22:39
@mjhenkes
Copy link

mjhenkes commented Jun 6, 2019

@jamiebuilds, thanks! 🙏

@s100
Copy link

s100 commented May 4, 2021

Folks, this is an extreme long shot, but is there any chance of backporting this fix from [email protected] to [email protected], and releasing it as [email protected]? There is a security issue upstream which the folks upstream are ignoring. Backporting this fix would also resolve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants