Rebuild onboarding modal #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm going to start changing the UI code to use React, so we need these packages.
This allows us to have component-specific CSS that all get nicely bundled together
This mirrors the one that we wrote for Svelte
This commit does a few things: - it rebuilds the token entering modal completely - it improves the UX by not alert()'ing when there is no token - it will open the modal on each startup, if the token still doesn't exist
We need to mock out the obsidian library since its not actually there at runtime when testing
jamiebrynes7
force-pushed
the
feature/redesign-onboarding
branch
from
3e4e0bf
to
a8d46da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
sassto process CSS instead of simply copying it