Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build fails with maturin 1.8.0 #224

Closed
wu7zh opened this issue Dec 27, 2024 · 1 comment · Fixed by #226
Closed

Build fails with maturin 1.8.0 #224

wu7zh opened this issue Dec 27, 2024 · 1 comment · Fixed by #226

Comments

@wu7zh
Copy link

wu7zh commented Dec 27, 2024 •
edited
Loading

When building (on gentoo during an update) I am getting the error:

maturin failed

Caused by: project.version field is required in pyproject.toml unless it is present in the project.dynamic list

This is due to a change in maturin 1.8.0, and needs to be fixed to be able to build.
@wu7zh
Copy link
Author

wu7zh commented Dec 28, 2024

Added a PR #225

heirecka added a commit to heirecka/jellyfish that referenced this issue Dec 28, 2024
@heirecka
pyproject.toml: Allow maturin >= 1.8.0 to fill the version
e4936cc 
maturin >= 1.8.0 stopped filling the version from Cargo.toml, because
the spec only allows this, when the metadata key is listed in
`dynamic` [1][2].

Fixes jamesturk#224.

[1] https://packaging.python.org/en/latest/specifications/pyproject-toml/#dynamic
[2] PyO3/maturin#2390
@heirecka heirecka mentioned this issue Dec 28, 2024
Merged
@GUUser91 GUUser91 mentioned this issue Dec 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pyproject.toml: Allow maturin >= 1.8.0 to fill the version heirecka/jellyfish
1 participant
@wu7zh