Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript Translate #6

Closed
aljibbs opened this issue Jan 7, 2018 · 4 comments
Closed

Typescript Translate #6

aljibbs opened this issue Jan 7, 2018 · 4 comments

Comments

@aljibbs
Copy link

aljibbs commented Jan 7, 2018

Will you translate this library into a typescript version anytime soon ?
@jamesssooi
Copy link
Owner

Hi @aljibbs, while I do see the merits of Typescript (and loving it!), I don't see a big reason to port the whole project over to Typescript given its relatively small code base.

Or do you mean creating type definition files for Croppr?

@aljibbs
Copy link
Author

aljibbs commented Jan 22, 2018

Yeah that's what I meant. Will you create type definitions for Croppr ?

@jamesssooi
Copy link
Owner

It's definitely a great helpful addition. I'm already working on it, so do expect it to be released the next few days!

jamesssooi added a commit that referenced this issue Jan 29, 2018
@jamesssooi
Merge branch 'feat/typings' into develop (#6)
b574baf
@jamesssooi
Copy link
Owner

Typescript typings has been added and released in v2.2.1. Happy coding in confidence and safety!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aljibbs @jamesssooi