Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.6.21 - Rollup to Multicurrency Parents Bugfix #580

Merged
merged 8 commits into from
Apr 9, 2024
Merged

Conversation

jamessimone
Copy link
Owner

  • Fixes an issue reported by Joseph Mason where rollups to different parents accidentally cached
    the converted IsoCode value of the first child -> parent multicurrency conversion
  • Adds safety step in pipeline to ensure scratch orgs are deleted properly

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.60%. Comparing base (2a9e4de) to head (31dbadf).

❗ Current head 31dbadf differs from pull request most recent head fdea546. Consider uploading reports for the commit fdea546 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #580      +/-   ##
==========================================
+ Coverage   96.58%   96.60%   +0.01%     
==========================================
  Files          32       32              
  Lines        6681     6681              
  Branches       61       61              
==========================================
+ Hits         6453     6454       +1     
+ Misses        223      222       -1     
  Partials        5        5              
Flag Coverage Δ
Apex 96.83% <100.00%> (+0.01%) ⬆️
LWC 92.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamessimone jamessimone merged commit 936c135 into main Apr 9, 2024
1 check passed
@jamessimone jamessimone deleted the v1.6.21 branch April 9, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants