remove default value for max_connections #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the low default value for the maximum number of connections is already conflicting with the postgres configuration on ubuntu versions for the second time (18.04, now 19.04). it seems wiser to let the postgres configuration of the OS decide the default value for the maximum number of connections (it can still be modified via the constructor).
|
@jamesnunn ping! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #14
the low default value for the maximum number of connections is already
conflicting with the postgres configuration on ubuntu versions for the
second time (18.04, now 19.04).
it seems wiser to let the postgres configuration of the OS decide the
default value for the maximum number of connections (it can still be
modified via the constructor).