fix: cobs accumulator out-of-bounds index when data is 1 byte too long #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is an off-by-one error in bounds checking which may lead to
panic!
inself.extend_unchecked()
.When calling:
the
take
slice has length ofn + 1
(slice::split_at), but currently theif
condition checks for sizen
.I added a test case that demonstrates the issue using
CobsAccumulator<11>
and feeding it with a 12-byte message. Without the fix this will panic: