Minor: Fix off-by-one in varint size calculation #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for cute-starship-2d9c9b processing.
|
✅ Deploy Preview for cute-starship-2d9c9b canceled.
|
|
Thanks, great catch! |
jamesmunns
pushed a commit
that referenced
this pull request
Aug 31, 2023
kodiakhq bot
referenced
this pull request
in X-oss-byte/Nextjs
Sep 22, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [postcard](https://togithub.com/jamesmunns/postcard) | workspace.dependencies | patch | `1.0.4` -> `1.0.7` | --- ### Release Notes <details> <summary>jamesmunns/postcard (postcard)</summary> ### [`v1.0.7`](https://togithub.com/jamesmunns/postcard/blob/HEAD/CHANGELOG.md#107---Unreleased) [Compare Source](https://togithub.com/jamesmunns/postcard/compare/v1.0.6...v1.0.7) ### [`v1.0.6`](https://togithub.com/jamesmunns/postcard/blob/HEAD/CHANGELOG.md#106---107) [Compare Source](https://togithub.com/jamesmunns/postcard/compare/v1.0.5...v1.0.6) - Fix off-by-one in varint size calculation by [@​Palladinium](https://togithub.com/Palladinium) in [https://github.com/jamesmunns/postcard/pull/111](https://togithub.com/jamesmunns/postcard/pull/111) - Add specific error for Crc errors by [@​CBJamo](https://togithub.com/CBJamo) in [https://github.com/jamesmunns/postcard/pull/112](https://togithub.com/jamesmunns/postcard/pull/112) ### [`v1.0.5`](https://togithub.com/jamesmunns/postcard/blob/HEAD/CHANGELOG.md#105---106) [Compare Source](https://togithub.com/jamesmunns/postcard/compare/v1.0.4...v1.0.5) - Add cfg information to docs by [@​dtolnay](https://togithub.com/dtolnay) in [https://github.com/jamesmunns/postcard/pull/108](https://togithub.com/jamesmunns/postcard/pull/108) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/sammyfilly/Nextjs).
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reading through the varint implementation in postcard to sanity-check one of my own implementations, and I spotted a mistake in the code that calculates the maximum number of varint bytes an integer datatype can take.
The old version adds 7 instead of 6, so instead of the behaviour documented in the comment it would overestimate the number of varint bytes required by one for datatypes whole size is a multiple of 7 bits. Since there are thankfully none among the common integer datatypes, the behaviour is correct both before and after the change.