Give MonkeyCache.FileStore the ability to be FIPS compliant #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, i like that! let people pass in what they desire :) I will look at this soon :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the MonkeyCache.FileStore barrel uses the MD5 hash algorithm. This will throw an exception on systems that have FIPS enabled. For more info on FIPS - see:
https://docs.microsoft.com/en-us/windows/security/threat-protection/fips-140-validation
This patch modifies the barrel ctor to optionally allow the HashAlgorithm to be specified. If a HashAlgorithm is not specified, it defaults to current behavior (using MD5).