Bug/permission check #333
Merged
Bug/permission check #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Location", whether or not background updates are enabled. The "always" permission is used for things like startMonitoringSignificantLocationChanges; services that wake up your application even if it is not running in the background or foreground.
…a iOS 14 workaround patch.
…include a iOS 14 workaround patch." This reverts commit e8cfc97.
…is sufficient even if AllowBackgroundUpdates is true. My proposal is to default to just WhenInUse and either let the programmer request Always permission on their own, or they can set a LocationSettings flag to require always permission.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take a moment to fill out the following:
Fixes #329 and #328
Changes Proposed in this pull request: