Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple enhancements for new version #68

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

sergotail
Copy link

  • Added customization for events and event listener to its overrideing and usage of custom events
  • Added customization for flash messages, added separate trait for it to allow event listener overriding
  • GeoIP timezone info retrieval now is in separate trait for customization, also fixed its logic to work with different geoip info formats
  • Added empty date/datetime string customization
  • Added Timezone::toLocal method to use Carbon instance with set user-side timezone, e.g. for diffForHumans usage
  • Added per-user timezone overwrite flag
  • Added HasTimezone trait to support different package timezone attributes data sources, not only users table
  • Minor codestyle fixes done

@jamesmills
Copy link
Owner

wow!

Sorry @sergotail I totally missed this. Thank you for taking the time to contribute all this.

I'll have to find some time to dig into it all, thanks again!

@jamesmills
Copy link
Owner

@sergotail I've just found time to go over this and I think most of what you have done is the basis for a version 2 of this package and I think we could probably squash all other PR's once we use your updates as the base for v2.

I guess my question is what happens when we add all this stuff to a v2 and people want to upgrade, I don't really have time to write an upgrade guide.

I also think there is a handful of other PR's that we might need to merge into this. I'm also thinking we could remove some stuff like the flash messages and config and just allow people to hook into our internal events if they want to do something....

I've also just seen a PR about not using the DB to store this but just add it to the session. Maybe an option to add a "don't persist in database flag" or something.

What do you think? Shall we create a 2.0.0 branch and then merge your changes into that and then work on the other outstanding requests?

Thanks so much for everything!

@sergotail
Copy link
Author

@jamesmills Sorry for late answer, i've just found time to go back to your great package and my pull request. I think it's a great idea to start 2.0.0 branch and merge my changes into it. Also i would add some minor fixes to this branch that i found after current pull request created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants