Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support flags in ZADD #232

Closed
bmerry opened this issue Jan 15, 2019 · 0 comments
Closed

Support flags in ZADD #232

bmerry opened this issue Jan 15, 2019 · 0 comments

Comments

@bmerry
Copy link
Collaborator

bmerry commented Jan 15, 2019

ZADD supports flags NX, XX, CH and INCR, which are not yet implemented.
adamantike added a commit to adamantike/fakeredis that referenced this issue Aug 4, 2019
@adamantike
Support NX/XX/CH flags in ZADD command
2d8dcf3 
Add support for the new `NX`, `XX`, and `CH` flags in the `ZADD`
command, which can only be provided with `redis-py` version 3 installed.

This fixes a subset of what's filed in jamesls#232. `INCR` flag will be
implemented in a different pull request, as it's completely different to
handle.
@adamantike adamantike mentioned this issue Aug 4, 2019
Merged
bmerry pushed a commit that referenced this issue Aug 26, 2019
@adamantike @bmerry
Support NX/XX/CH flags in ZADD command (#247)
28a7591 
Support NX/XX/CH flags in ZADD command

Add support for the new `NX`, `XX`, and `CH` flags in the `ZADD`
command, which can only be provided with `redis-py` version 3 installed.

This fixes a subset of what's filed in #232. `INCR` flag will be
implemented in a different pull request, as it's completely different to
handle.
@bmerry bmerry closed this as completed in 1cb465b Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bmerry