Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

future.types.newbytes does not encode correctly #199

Closed
bmerry opened this issue Aug 2, 2018 · 0 comments
Closed

future.types.newbytes does not encode correctly #199

bmerry opened this issue Aug 2, 2018 · 0 comments
Assignees
@bmerry

Comments

@bmerry
Copy link
Collaborator

bmerry commented Aug 2, 2018

python-future provides future.types.newbytes which is meant to behave like the Python 3 bytes type in Python 2. However, fakeredis.to_bytes doesn't handle it correctly.
@bmerry bmerry self-assigned this Aug 2, 2018
bmerry added a commit that referenced this issue Aug 2, 2018
@bmerry
Handle future.types.newbytes
0e0a002 
It was previously being wrapped in bytes(), which ends up wrapping it in
b'...'. Things that match isinstance(x, bytes) are now returned as-is.

Fixes #199
@bmerry bmerry closed this as completed in fbe6d75 Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmerry bmerry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bmerry