Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the test server #270

Merged
merged 5 commits into from
Mar 22, 2022
Merged

Fix the test server #270

merged 5 commits into from
Mar 22, 2022

Conversation

jameslittle230
Copy link
Owner

Problems:

  • The feature was hidden behind a Cargo feature that didn't exist, so it was never being compiled in
  • The feature was out of date and didn't compile as-is
  • The demo webpage referenced old CDN assets
  • The value of the index_path command line argument wasn't being extracted properly since I was querying it with the incorrect string index

Fixes #269

@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #270 (d814f1f) into master (eeaca67) will increase coverage by 0.46%.
The diff coverage is 75.00%.

❗ Current head d814f1f differs from pull request most recent head e47d212. Consider uploading reports for the commit e47d212 to get more accurate results

@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
+ Coverage   72.44%   72.91%   +0.46%     
==========================================
  Files          53       52       -1     
  Lines        2174     2160      -14     
  Branches      104      104              
==========================================
  Hits         1575     1575              
+ Misses        598      584      -14     
  Partials        1        1              
Impacted Files Coverage Δ
stork-cli/src/clap.rs 100.00% <ø> (ø)
stork-cli/src/main.rs 0.00% <0.00%> (ø)
stork-lib/src/index_v3/build/fill_stems.rs 100.00% <ø> (ø)
stork-lib/src/index_v3/mod.rs 70.37% <ø> (ø)
stork-lib/src/index_v3/build/fill_containers.rs 91.80% <100.00%> (ø)
stork-lib/src/index_v3/build/mod.rs 98.57% <100.00%> (ø)
stork-lib/src/index_v3/search/mod.rs 95.77% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2ed81c...e47d212. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Mar 22, 2022

Benchmarks

BenchmarkBaselineContenderComparison
build/federalist167.6459166.0550.99× 🎉
federalist.st1125.4561125.4561.0×
search/federalist/liberty1.45811.45451.0×
stork.js21.8821.881.0×
stork.wasm356.523356.5231.0×

Baseline: d2ed81c; Comparison: e47d212

@jameslittle230 jameslittle230 merged commit ed91504 into master Mar 22, 2022
@jameslittle230 jameslittle230 deleted the STORK-269/fix-test-server branch March 22, 2022 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test server does not appear to work
1 participant