Support more units and ignore case in file-size config options #277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #274
Some configuration options, like
--max-allowed-size-compressed
, allow you to change file-size-based thresholds that influence check results.These are currently evaluated in "bibytes", but are not correctly document. e.g.
"1M" = "1 mebibyte" = 1024^2 bytes
, butpydistcheck
docs say that"1M" = "1 megabyte"
, which is 1,000,000 bytes.This PR:
Mi
orGi
"MB"
for megabytes5KB, 5kB, 5Kb, 5kb
Why have the single-letter aliases like
M
support e.g. mebibytes instead of megabytesTo avoid breaking any existing
pydistcheck
uses that have been relying on that behavior.And because I couldn't find any reference suggesting a preferred way to interpret the unit
M
.