Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix globe component #96

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

david-mears-2
Copy link
Contributor

@david-mears-2 david-mears-2 commented Nov 18, 2024

Currently on main the antarctica series is missing from the globe, as are the colors, and the ability to hover and select.

This change should have been added in a merge of the globe refactor PR and the Antarctica PR, but wasn't.

These failures should be caught by the component tests next time, once the branch with tests in is merged.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.15%. Comparing base (a63c6b7) to head (52ea4cc).
Report is 10 commits behind head on jidea-168-globe-component-tests.

Additional details and impacted files
@@                         Coverage Diff                          @@
##           jidea-168-globe-component-tests      #96       +/-   ##
====================================================================
+ Coverage                             1.44%   37.15%   +35.71%     
====================================================================
  Files                                   55       56        +1     
  Lines                               146190   146237       +47     
  Branches                               327      373       +46     
====================================================================
+ Hits                                  2116    54338    +52222     
+ Misses                              144057    91883    -52174     
+ Partials                                17       16        -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@david-mears-2 david-mears-2 merged commit d62f350 into jidea-168-globe-component-tests Nov 19, 2024
6 checks passed
@david-mears-2 david-mears-2 deleted the fix-globe-component branch November 19, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants