Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIDEA-171: Add Antarctica to the globe #94

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

david-mears-2
Copy link
Contributor

@david-mears-2 david-mears-2 commented Nov 12, 2024

Has been bugging me since Pratik pointed out it was missing.

This uses the geodata that comes along with amcharts, in the lowest provided resolution.

image

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.63%. Comparing base (af05202) to head (d3773f2).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #94   +/-   ##
=======================================
  Coverage    1.62%    1.63%           
=======================================
  Files          54       54           
  Lines      146164   146169    +5     
  Branches      306      306           
=======================================
+ Hits         2380     2385    +5     
  Misses     143768   143768           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@M-Kusumgar M-Kusumgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay! looks good to me

@david-mears-2 david-mears-2 merged commit eacf1af into main Nov 15, 2024
6 checks passed
@david-mears-2 david-mears-2 deleted the jidea-171-add-antarctica branch November 15, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants