JIDEA-193: Globe: Color disputed lands according to neighboring countries' color #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intention is to prevent the Abyei region (between Sudan and South Sudan) from looking like a selectable country, which it did because it was colored with the default color but was surrounded by unselectable countries.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
=======================================
Coverage 1.62% 1.62%
=======================================
Files 54 54
Lines 146163 146163
Branches 306 306
=======================================
Hits 2379 2379
Misses 143768 143768
Partials 16 16 ☔ View full report in Codecov by Sentry. |
david-mears-2
changed the title
david-mears-2
requested review from
EmmaLRussell and
M-Kusumgar
and removed request for
EmmaLRussell
M-Kusumgar
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention is to prevent the Abyei region (between Sudan and South Sudan) from looking like a selectable country, which it did because it was colored with the default color but was surrounded by unselectable countries.
Before
After