Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jidea-182 add world map disclaimer and attribution #85

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

EmmaLRussell
Copy link
Contributor

Adds map-related text by Ellie already reviewed on Teams

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.62%. Comparing base (3add58a) to head (5e47ae6).
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #85   +/-   ##
=======================================
  Coverage    1.62%    1.62%           
=======================================
  Files          54       54           
  Lines      146162   146163    +1     
  Branches      306      306           
=======================================
+ Hits         2378     2379    +1     
  Misses     143768   143768           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from jidea-181-versions-on-about to main October 29, 2024 13:33
@EmmaLRussell
Copy link
Contributor Author

I'm skipping the slow analysis test for now, but have made a ticket to reinstate it when slow analyses return in the next daedalus PR: https://mrc-ide.myjetbrains.com/youtrack/issue/JIDEA-184/Reinstate-slow-analysis-e2e-test

@EmmaLRussell EmmaLRussell marked this pull request as ready for review October 29, 2024 15:00
Copy link
Contributor

@M-Kusumgar M-Kusumgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof yes, gotta save our asses in case someone comes for us

@EmmaLRussell EmmaLRussell merged commit 1a55714 into main Oct 29, 2024
6 checks passed
@EmmaLRussell EmmaLRussell deleted the jidea-182-boundaries-info branch October 29, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants