Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make run button functional #25
Make run button functional #25
Changes from 21 commits
7d9c378
02be36f
d1d4f9c
7b146ba
52b12eb
bcb53f2
7434c9d
782a8db
f45d8e9
12b7581
8c0c4f5
0906bca
0966d2b
143063c
fbb2a05
2a03920
67ba34d
c3a4d8e
fbc712e
93ca120
501d92a
d84c44c
3e43583
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this actually necessary? A Playwright timing issue? It should be possible to write Playwright tests so that they wait for a condition to become true. I think I'd rather have messy tests than somewhat inexplicable properties of the code that are only there because of test behaviour. If it really isn't then let's have a comment explaining it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Luckily, this problem disappears next PR, because by then we can wait for version data as our signal that everything is mounted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
POST "scenarios" seems a bit odd when it's only posting a single scenario - or is the idea that it will do multiple scenarios when we do the comparison feature? (In that case it will be POSTing an array of parameters potentially..)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was imagining all of the scenario-related endpoints living under a single 'scenarios' namespace, rather than varying between 'scenario' and 'scenarios' depending on the use case. I believe in CRUD it is conventional to standardize on the plural form in route names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's a bit uneasy. Fair enough!
Check warning on line 144 in components/ParameterForm.vue
Codecov / codecov/patch
components/ParameterForm.vue#L143-L144
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linkage between these clauses wasn't immediately obvious to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through an adventure since writing this, submitted a PR to clarify the docs of the nuxt pinia module, and eventually the maintainer let me know that in fact "you don't need to pass the pinia instance within setup"
vuejs/pinia#2766
As such, the next PR removes this, here: https://github.com/jameel-institute/daedalus-web-app/pull/27/files#diff-433a9abd4ca70520f69fc064c160bb093918ce26dda6087a8bbfdbe2895d1944
Check warning on line 41 in layouts/default.vue
Codecov / codecov/patch
layouts/default.vue#L40-L41